feat: batch revoke add alert for simulation failed (#2690)

* feat: batch revoke add alert for simulation failed * feat: add debug code
RabbyHub · Dec 19, 2024 · ef71379 · ef71379
1 parent 46764de
commit ef71379
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 3 deletions.
diff --git a/_raw/locales/en/messages.json b/_raw/locales/en/messages.json
@@ -829,7 +829,8 @@
         "ledgerSended": "Please sign the request on Ledger ({{current}}/{{total}})",
         "ledgerSending": "Sending signing request ({{current}}/{{total}})",
         "ledgerAlert": "Please open Ethereum App on your Ledger device",
-        "ledgerSigned": "Signed. Creating transaction ({{current}}/{{total}})"
+        "ledgerSigned": "Signed. Creating transaction ({{current}}/{{total}})",
+        "simulationFailed": "Simulation Failed"
       }
     },
     "gasTopUp": {

diff --git a/_raw/locales/zh-CN/messages.json b/_raw/locales/zh-CN/messages.json
@@ -910,7 +910,8 @@
         "ledgerSigned": "签署。创建交易（{{current}}/{{total}}）",
         "ledgerSending": "正在发送签名请求（{{current}}/{{total}}）",
         "confirmRevokeLedger": "使用账本地址，您可以一键批量撤销 {{count}} 个批准。",
-        "confirmRevokePrivateKey": "使用助记词或私钥地址，您可以一键批量撤销 {{count}} 个批准。"
+        "confirmRevokePrivateKey": "使用助记词或私钥地址，您可以一键批量撤销 {{count}} 个批准。",
+        "simulationFailed": "交易模拟失败"
       }
     },
     "connect": {

diff --git a/src/ui/utils/sendTransaction.ts b/src/ui/utils/sendTransaction.ts
@@ -32,6 +32,7 @@ export enum FailedCode {
   GasNotEnough = 'GasNotEnough',
   GasTooHigh = 'GasTooHigh',
   SubmitTxFailed = 'SubmitTxFailed',
+  SimulationFailed = 'SimulationFailed',
   DefaultFailed = 'DefaultFailed',
 }
 
@@ -255,6 +256,10 @@ export const sendTransaction = async ({
     ? (await Browser.storage.local.get('DEBUG_OTHER_CHAIN_GAS_USD_LIMIT'))
         .DEBUG_OTHER_CHAIN_GAS_USD_LIMIT || 5
     : 5;
+  const DEBUG_SIMULATION_FAILED = process.env.DEBUG
+    ? (await Browser.storage.local.get('DEBUG_SIMULATION_FAILED'))
+        .DEBUG_SIMULATION_FAILED
+    : false;
 
   // generate tx with gas
   const transaction: Tx = {
@@ -269,7 +274,13 @@ export const sendTransaction = async ({
 
   let failedCode;
   let canUseGasAccount: boolean = false;
-  if (isGasNotEnough) {
+
+  // random simulation failed for test
+  if (DEBUG_SIMULATION_FAILED && Math.random() > 0.5) {
+    failedCode = FailedCode.SimulationFailed;
+  } else if (!preExecResult?.balance_change?.success) {
+    failedCode = FailedCode.SimulationFailed;
+  } else if (isGasNotEnough) {
     //  native gas not enough check gasAccount
     if (autoUseGasAccount && gasAccount?.sig && gasAccount?.accountId) {
       const gasAccountCanPay = await checkEnoughUseGasAccount({

diff --git a/src/ui/views/ApprovalManagePage/components/BatchRevoke/useBatchRevokeTask.ts b/src/ui/views/ApprovalManagePage/components/BatchRevoke/useBatchRevokeTask.ts
@@ -66,6 +66,9 @@ export const FailReason = {
   [FailedCode.DefaultFailed]: i18n.t(
     'page.approvals.revokeModal.defaultFailed'
   ),
+  [FailedCode.SimulationFailed]: i18n.t(
+    'page.approvals.revokeModal.simulationFailed'
+  ),
 };
 
 export type AssetApprovalSpenderWithStatus = AssetApprovalSpender & {