Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ledger sign eip712 #2026

Merged
merged 1 commit into from
Feb 2, 2024
Merged

fix: ledger sign eip712 #2026

merged 1 commit into from
Feb 2, 2024

Conversation

heisenberg-2077
Copy link
Contributor

No description provided.

@vvvvvv1vvvvvv vvvvvv1vvvvvv mentioned this pull request Jan 31, 2024
Open
@0x398
Copy link

0x398 commented Jan 31, 2024

Please address #1816 (comment) before merging.
Blind signing is so reckless, especially after recent attack on ledger library which showed that you can not blindly trust updates even from big vendors.

@vvvvvv1vvvvvv vvvvvv1vvvvvv merged commit bf605bc into develop Feb 2, 2024
8 checks passed
@vvvvvv1vvvvvv vvvvvv1vvvvvv deleted the fix/ledger-typeddata branch February 2, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heisenberg-2077 @0x398 @vvvvvv1vvvvvv