Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verify receive address on BitBox02 hardware #2377

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Tomasvrba
Copy link
Contributor

Addresses: #599

Adds a button to verify address on device screen when the account is a BitBox02 imported account
The functionality is pretty simple, but please let me know if there are any issues with how I did it

Also if there are any issues with the UI and styling, I reused your "Eye" icon, which maybe you'll want to change to avoid confusion, let me know if you'd like a different icon for this, and what kind

The CSS should only change when this button appears, so those changes shouldn't touch anything else

Not sure how you handle your CHANGELOGS, let me know if I should add the feature somewhere

Looks like this:
1

Would be nice to maybe add the button in a couple more places that are easier to access, but I'd like your feedback on that first

  • On the main screen next to the copy button when using the BitBox:
    2

  • As an additional row or button on the Address Detail screen:
    3

@benma
Copy link
Contributor

benma commented Aug 13, 2024

ping @vvvvvv1vvvvvv, this would be a great feature to have.

@benma
Copy link
Contributor

benma commented Oct 13, 2024

ping @vvvvvv1vvvvvv. It's a simple and small diff, please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants