Feat: Add Button to Display Address on Ledger #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Ledger devices include a screen, enabling users to securely verify wallet addresses directly on the device. This feature is essential to the security model of hardware wallets, allowing users to confirm they truly control the keys for a particular address before sending funds. Without this feature, compromised wallet software can easily deceive users into sending funds to an attacker-controlled address.
This PR serves as a working proof of concept to show how straightforward it is to implement this feature. If a Rust dev with almost no TypeScript experience and no prior familiarity with this codebase can set this up in a few hours, it seems feasible that the dev team could properly integrate this functionality very easily.
I hope this demonstrates its value and feasibility – and I encourage the team to consider it for the security benefits it provides.