Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable taps during async animations #177

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

thedalelakes
Copy link

Description

Currently, if a tutorial is in the foreground, and the user taps something, an animation occurs. This animation does not reject additional taps while the animation is in progress.

This PR prevents spurious taps from being registered while there is an active animation.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I open this PR to the develop branch.
  • I have added a description of the change under [next] in CHANGELOG.md.
  • I ran flutter format --set-exit-if-changed --dry-run . and has success.

Breaking Change

Does your PR require Flame users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md).
  • No, this is not a breaking change.

Copy link
Owner

@RafaelBarbosatec RafaelBarbosatec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Sorry for late.
If is possible resolve the conflicts.

@3DExtended
Copy link

@thedalelakes Hey! Thank you so much for doing this!

Could you resolve those conflicts? I'd love to use this PR....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants