crypto: runtime deprecate Hash constructor

PR-URL: nodejs#51880 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
RafaelGSS · Mar 12, 2024 · de0602d · de0602d
1 parent 0b4cdb4
commit de0602d
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -3563,12 +3563,15 @@ release lines. Please use [`dirent.parentPath`][] instead.
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/51880
+    description: Runtime deprecation.
   - version: v21.5.0
     pr-url: https://github.com/nodejs/node/pull/51077
     description: Documentation-only deprecation.
 -->
 
-Type: Documentation-only
+Type: Runtime
 
 Calling `Hash` class directly with `Hash()` or `new Hash()` is
 deprecated due to being internals, not intended for public use.

diff --git a/lib/crypto.js b/lib/crypto.js
@@ -231,7 +231,7 @@ module.exports = {
   DiffieHellman,
   DiffieHellmanGroup,
   ECDH,
-  Hash,
+  Hash: deprecate(Hash, 'crypto.Hash constructor is deprecated.', 'DEP0179'),
   Hmac,
   KeyObject,
   Sign,

diff --git a/test/parallel/test-crypto-hash.js b/test/parallel/test-crypto-hash.js
@@ -276,3 +276,13 @@ assert.throws(
   assert.strictEqual(a.digest('hex'), b.digest('hex'));
   assert.strictEqual(c.digest('hex'), d.digest('hex'));
 }
+
+{
+  crypto.Hash('sha256');
+  common.expectWarning({
+    DeprecationWarning: [
+      ['crypto.Hash constructor is deprecated.',
+       'DEP0179'],
+    ]
+  });
+}