Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds streaming versions and refactors code #102

Conversation

tomkail
Copy link
Collaborator

@tomkail tomkail commented Nov 3, 2024

Adds streaming versions and refactors code significantly to avoid duplication

Copy link
Member

@StephenHodgson StephenHodgson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

tomkail and others added 4 commits November 4, 2024 15:12
…TranscribedAudioClip.cs

Co-authored-by: Stephen Hodgson <[email protected]>
…versions' of https://github.com/RageAgainstThePixel/com.rest.elevenlabs into adds-WithTimestamp-functions-for-regular-and-streaming-versions

# Conflicts:
#	ElevenLabs/Packages/com.rest.elevenlabs/Runtime/Models/PartialTranscribedAudioClip.cs
@StephenHodgson StephenHodgson dismissed their stale review November 5, 2024 04:28

pushed some change requests

@StephenHodgson
Copy link
Member

@tomkail everything starting to look good. Just needs Unit tests for all the new methods

@StephenHodgson StephenHodgson merged commit c886ef6 into development Nov 24, 2024
9 checks passed
@StephenHodgson StephenHodgson deleted the adds-WithTimestamp-functions-for-regular-and-streaming-versions branch November 24, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants