Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop configuration update #21

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 19 additions & 16 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,31 +1,34 @@
PATH
remote: .
specs:
ragnarson-stylecheck (0.8.2)
ragnarson-stylecheck (1.0.0)
rake (>= 10.0)
rubocop (~> 0.64)
rubocop (~> 1.18.3)

GEM
remote: https://rubygems.org/
specs:
ast (2.4.0)
jaro_winkler (1.5.2)
parallel (1.17.0)
parser (2.6.2.0)
ast (~> 2.4.0)
psych (3.1.0)
ast (2.4.2)
parallel (1.20.1)
parser (3.0.2.0)
ast (~> 2.4.1)
rainbow (3.0.0)
rake (12.3.2)
rubocop (0.66.0)
jaro_winkler (~> 1.5.1)
rake (13.0.6)
regexp_parser (2.1.1)
rexml (3.2.5)
rubocop (1.18.3)
parallel (~> 1.10)
parser (>= 2.5, != 2.5.1.1)
psych (>= 3.1.0)
parser (>= 3.0.0.0)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml
rubocop-ast (>= 1.7.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 1.6)
ruby-progressbar (1.10.0)
unicode-display_width (1.5.0)
unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.8.0)
parser (>= 3.0.1.1)
ruby-progressbar (1.11.0)
unicode-display_width (2.0.0)

PLATFORMS
ruby
Expand Down
5 changes: 3 additions & 2 deletions config/rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@ AllCops:
- bin/**
- vendor/bundle/**/*
- node_modules/**/*
NewCops: disable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because new crops can affect style of our code in way that we don't want, and due to that I wasn't sure if it will be right approach.
I can enable all of new cops, and check how they will affect our code. Or just, enable it. Please let me know what you think.


##################### Layout ##################################

Layout/AlignHash:
Layout/HashAlignment:
EnforcedHashRocketStyle: table
EnforcedColonStyle: table

Expand Down Expand Up @@ -110,7 +111,7 @@ Metrics/BlockLength:
- "spec/**/*.rb"
- "config/**/*.rb"

Metrics/LineLength:
Layout/LineLength:
Max: 120
# To make it possible to copy or click on URIs in the code, we allow lines
# contaning a URI to be longer than Max.
Expand Down
6 changes: 3 additions & 3 deletions ragnarson-stylecheck.gemspec
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
Gem::Specification.new do |s|
s.name = "ragnarson-stylecheck"
s.version = "0.8.2"
s.version = "0.9.0"
s.summary = "Automatic style check for ragnarson projects"
s.description = "Wraps rubocop for simple and consisten experience"
s.authors = ["Grzesiek Kołodziejczyk", "Maciej Małecki", "Oskar Szrajer", "Piotr Marciniak"]
s.authors = ["Grzesiek Kołodziejczyk", "Maciej Małecki", "Oskar Szrajer", "Piotr Marciniak", "Michał Gołdys"]
s.email = "[email protected]"
s.files = Dir["{config,lib}/**/*", "MIT-LICENSE", "README.md", "./"]
s.homepage = "https://github.com/ragnarson/ragnarson-stylecheck"
s.license = "MIT"

s.add_development_dependency "bundler", "~> 1.10"
s.add_dependency "rake", ">= 10.0"
s.add_dependency "rubocop", "~> 0.64"
s.add_dependency "rubocop", "~> 1.18.3"
end