-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubocop configuration update #21
Open
michalgoldys
wants to merge
8
commits into
master
Choose a base branch
from
rubocop-configuration-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c321ecd
Generate new Gemfile after updating rubocop version
michalgoldys 20e3e2d
Update rubocop version
michalgoldys 201a8aa
Update configuration file to meet new variable names
michalgoldys 063b798
Update line lenght parameter
michalgoldys c4ad6cb
Revert changes in LineLenght
michalgoldys 90a2b61
Update rubocop to latest version
michalgoldys 7904acf
Rebuild Gemfile.lock due to rubocop version update
michalgoldys 26ea6b5
Update project version as Grzegorz recommends
michalgoldys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,15 @@ | ||
Gem::Specification.new do |s| | ||
s.name = "ragnarson-stylecheck" | ||
s.version = "0.8.2" | ||
s.version = "0.9.0" | ||
s.summary = "Automatic style check for ragnarson projects" | ||
s.description = "Wraps rubocop for simple and consisten experience" | ||
s.authors = ["Grzesiek Kołodziejczyk", "Maciej Małecki", "Oskar Szrajer", "Piotr Marciniak"] | ||
s.authors = ["Grzesiek Kołodziejczyk", "Maciej Małecki", "Oskar Szrajer", "Piotr Marciniak", "Michał Gołdys"] | ||
s.email = "[email protected]" | ||
s.files = Dir["{config,lib}/**/*", "MIT-LICENSE", "README.md", "./"] | ||
s.homepage = "https://github.com/ragnarson/ragnarson-stylecheck" | ||
s.license = "MIT" | ||
|
||
s.add_development_dependency "bundler", "~> 1.10" | ||
s.add_dependency "rake", ">= 10.0" | ||
s.add_dependency "rubocop", "~> 0.64" | ||
s.add_dependency "rubocop", "~> 1.18.3" | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because new crops can affect style of our code in way that we don't want, and due to that I wasn't sure if it will be right approach.
I can enable all of new cops, and check how they will affect our code. Or just, enable it. Please let me know what you think.