Skip to content

Commit

Permalink
Finalising Maintenance Release information for 2.4.6
Browse files Browse the repository at this point in the history
  • Loading branch information
neutronc committed Apr 3, 2021
1 parent 6cd6571 commit 3d73da4
Show file tree
Hide file tree
Showing 3 changed files with 123 additions and 54 deletions.
67 changes: 60 additions & 7 deletions Changelog.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Rails-18xx 2.4.5 Release
# Rails-18xx 2.4.6 Maintenance Release
This release is meant to show the current state of the Rails-18xx implementation.

Due to different reasons Rails-18xx 2.0 and 2.1 have not been release as production releases. We hope that the audience
Expand All @@ -23,12 +23,65 @@ We would like to **thank** the varios bug reporters and the developers who have
* Coal Minors merging round implementation needs to be tested.

## Bug Fixes
# Rails 2.4 Maintenance Version 6

* Various svg-Tiles werent configured correctly which lead to graphic error while resizing or moving the map. Issue
reported for 18NL/18TN by Lou Jerkich; Fixes done for 1837 1880 and 18Chesapeake
Major Contributor: Erik Vos
Minor Contributors : Martin Brumm, Marc Arndt


Fix for 18EU& others: Single Trains could cause a Java Exception on Mandatory Discard if not obsolete.
Fixes for 1837: Mine revenues of EPP and SPB are incorrect #376
1837: Sold-out company where president has <= 40% shares does not rise at end of SR #375
1837: More than 2 companies can have same par price #374
1837: Price drops one row for each sold share. #373
1837: Hexes K21 (U2 home) and L22 (town SE of U2) behave as unconnected
1837: Bosnia and Italy map hex colours #361

[1] In version 1, the S5 home hex location is still done in the initial round. It works, but is not according to the rules.
Status: Fixed, not yet released. During testing I discovered, that this action was assigned to the previous player (S4 owner) rather than the S5 owner. Apparently, the new player's turn was not yet started. This has been fixed (perhaps the code needs to be revisited).

[2] During testing several problems with coal company exchanges have been encountered. The code seems to offer this option only directly after a major company has floated. In practice, offering an exchange at the start of any round sometimes occurs and sometimes not, whether mandatory or optional. It has also happened automatically. Further testing is needed to sort this all out.
Status: fixed, should be in release 2.4.5 (this also applies to cases [3], [12] and [13]).
P.S.: I have no info yet on what is included in either release.

[3] If, after a coal company exchange, the related major company has too many trains, a "voluntary" train discard is offered, including a "None" option, even though it is really mandatory.
Status: see [2].

[4]-[8]: See next comment.

[9abc] No connection between preprinted tiles on hexes K21 (U2 home) and L22.
Status: Confirmed, cause still unknown. Discussed further in issue #360.

[10] Revenue rounding.
Status: Fixed, see issue #372 for details.

[11] Major capitalisation wrong (always 100%).
Status: Fixed, should be in release 2.4.5.

[12] Missing coal exchange rounds
Status: See [2].

[13] Forced coal merge does not give the owner a 10% share.
Status: Whatever was the situation in your run, it currently works fine. Should be in release 2.4.5.

[14] More than two companies with same par price.
Status: Fixed, see #374.

[15] Share price dropping should be as in 1835, not 1830.
Status: Fixed, see issue #373.

Edit: Added some remaining issues

[16ab] Crashes and other problems after buying the first 4-train.
Status: Testing past that point has not yet been started, as too many problems were found in earlier stages. Once these pre-4T problems are fixed to the extent that at least the finances are stable (so I don't have to recreate the SR4 test files again and again), further testing will start.

[17ab] Wrong share price movements for sold-out majors.
Status: Fixed, see #375.

[18] Different mine income values in v1 vs. v2?
Status: Fixed, see issue #376.

[19] Coal companies moving to different player?
Status: Never seen this. May have been fixed by the overhaul of the Coal Exchange Round some time ago. Consider it fixed until any contrary report is posted.

## Issues fixed:

* # 353
* # 356

2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
version=2.4.0-alpha
version=2.4.6
108 changes: 62 additions & 46 deletions src/main/resources/readme.txt
Original file line number Diff line number Diff line change
@@ -1,46 +1,62 @@
# Rails 2.0 Release Candidate 3

Major Contributor: Stefan Frey
Minor Contributors : Erik Vos, Chris Noon, Marek Jeszka, Martin Brumm

Be carefull while using this Release on games in progress on 1880 and 1835.
Due to the bugfixes here it is recommended that you replay the game using the game log from the old version.
It was not possible to make the savegames compatible if you ht the bug in your ongoing game (1835).

Fixes:
Fixed the Reload Command, missing was the RailsRoot Instance, Move some
Code around to resemble the initial load sequence.
Condition check for zero vertexes added (Marek Jeszka)

18AL : BonusToken Situation in 18AL
Quick Fix to make MapHex.upgrade working for hexes that have no station
and get upgraded to a station by a specialtilelay.
18AL has exactly that scenario and a number of other games too.

1880 : Fix Tile 8877 Shanghai Yellow value was wrong now corrected to 30
Fixing a bug in 1880s handling of players debt during emergency raise of trains.
Fixing the bug that an investor was still able to operate in Phase 4.
This apparently didnt get transfered to 2.0 RC1 while being fixed in 1.9.
Fixed the problem that a Special Train Buy using the RC could trigger a
phase change that wouldnt be recognised for Train Discards.
Fixed missing Stockmarket field F8.

1835 : Corrected game behaviour for 1835. According to Rules a sell share action only does NOT prolong the Stockround but is treated as a pass.
Only share buying actions are valid to prolong a round.


1856: Fixes by Erik Vos
fixed reload and press done button bug in 1856 (SF)
quick fix to remove token of ship company in 1856 in phase 5
(first 6 train), this is related to name and realName attributes of Phase (SF)

18EU: added 18EU test games from Volker Schnell, fixed two reporting issues (SF)
preliminary bugfix for 18EU offboard revenue modifier (SF)
fix for StartCompany_18EU equality problems (SF)
added third station on B/V -3005 tile to prevent error on upgrade to 581 (SF)

Internal reworking of code and structure too numerous to mention; all being done by Stefan Frey

UI Fixes: (Chris Noon)
allow use of the edit box on spin controls, i.e. font size.
Sizeable Fonts in Stockspace enabled
# Rails 2.4 Maintenance Version 6

Major Contributor: Erik Vos
Minor Contributors : Martin Brumm, Marc Arndt


Fix for 18EU& others: Single Trains could cause a Java Exception on Mandatory Discard if not obsolete.
Fixes for 1837: Mine revenues of EPP and SPB are incorrect #376
1837: Sold-out company where president has <= 40% shares does not rise at end of SR #375
1837: More than 2 companies can have same par price #374
1837: Price drops one row for each sold share. #373
1837: Hexes K21 (U2 home) and L22 (town SE of U2) behave as unconnected
1837: Bosnia and Italy map hex colours #361

[1] In version 1, the S5 home hex location is still done in the initial round. It works, but is not according to the rules.
Status: Fixed, not yet released. During testing I discovered, that this action was assigned to the previous player (S4 owner) rather than the S5 owner. Apparently, the new player's turn was not yet started. This has been fixed (perhaps the code needs to be revisited).

[2] During testing several problems with coal company exchanges have been encountered. The code seems to offer this option only directly after a major company has floated. In practice, offering an exchange at the start of any round sometimes occurs and sometimes not, whether mandatory or optional. It has also happened automatically. Further testing is needed to sort this all out.
Status: fixed, should be in release 2.4.5 (this also applies to cases [3], [12] and [13]).
P.S.: I have no info yet on what is included in either release.

[3] If, after a coal company exchange, the related major company has too many trains, a "voluntary" train discard is offered, including a "None" option, even though it is really mandatory.
Status: see [2].

[4]-[8]: See next comment.

[9abc] No connection between preprinted tiles on hexes K21 (U2 home) and L22.
Status: Confirmed, cause still unknown. Discussed further in issue #360.

[10] Revenue rounding.
Status: Fixed, see issue #372 for details.

[11] Major capitalisation wrong (always 100%).
Status: Fixed, should be in release 2.4.5.

[12] Missing coal exchange rounds
Status: See [2].

[13] Forced coal merge does not give the owner a 10% share.
Status: Whatever was the situation in your run, it currently works fine. Should be in release 2.4.5.

[14] More than two companies with same par price.
Status: Fixed, see #374.

[15] Share price dropping should be as in 1835, not 1830.
Status: Fixed, see issue #373.

Edit: Added some remaining issues

[16ab] Crashes and other problems after buying the first 4-train.
Status: Testing past that point has not yet been started, as too many problems were found in earlier stages. Once these pre-4T problems are fixed to the extent that at least the finances are stable (so I don't have to recreate the SR4 test files again and again), further testing will start.

[17ab] Wrong share price movements for sold-out majors.
Status: Fixed, see #375.

[18] Different mine income values in v1 vs. v2?
Status: Fixed, see issue #376.

[19] Coal companies moving to different player?
Status: Never seen this. May have been fixed by the overhaul of the Coal Exchange Round some time ago. Consider it fixed until any contrary report is posted.


0 comments on commit 3d73da4

Please sign in to comment.