-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Annulus Calculator #1647
Added Annulus Calculator #1647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Damini2004, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨
✅ Deploy Preview for calcdiverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Damini2004, You should add your calculator in alphabetical order in main index.html file of the project. |
@Damini2004 UI needs to be improved little bit. Also, you have specified that you will provide diagram? |
@Nihal4777 Changes done |
@Nihal4777 Added. |
@Damini2004 On small screens, there is overflow. |
Yes it will overflow because the radius is increased then it not possible to visible the bigger circle. so we can provide diagram of inner circle rather than outer circle. Are you ok with it. |
Where is the proper diagram, just white circle is visible. Also, that is hiding the result, pls fix @Damini2004 |
Are you working @Damini2004 |
Will close the PR if changes are not made today @Damini2004 |
Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @Damini2004 |
Fixes Issue🛠️
Closes #1576
Description👨💻
Added Annulus Calculator
Type of Change📄
Checklist✅
Screenshots/GIF📷