Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented pagination on the website #1660

Closed
wants to merge 2 commits into from

Conversation

pandeyji711
Copy link
Contributor

@pandeyji711 pandeyji711 commented Jul 16, 2024

@Rakesh9100

Fixes Issue 🛠️

Closes #1445

Description👨‍💻

I have implemented pagination on the homepage.
Made dedicated folder for pagination file, I have created pagination.css and pagination.js.

Type of Change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pandeyji711, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 57fc340
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/66af547568ae14000866b7cf
😎 Deploy Preview https://deploy-preview-1660--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Nihal4777
Copy link

@pandeyji711 You UI is different from what you've specified in issue?

image

@pandeyji711
Copy link
Contributor Author

@pandeyji711 You UI is different from what you've specified in issue?

image

@Nihal4777
currunt ui this matched with theam , and current one has additional feature of go to page with input,
but that was not fit with theam

@Rakesh9100
Copy link
Owner

Please hold, as this issue was assigned to someone else before, you can take another issues for now @pandeyji711

@Rakesh9100 Rakesh9100 added the status: standby ✊ This issue is on hold label Aug 4, 2024
@pandeyji711
Copy link
Contributor Author

@Rakesh9100 why did you assign me??

@Rakesh9100
Copy link
Owner

I did not notice that and got assigned to you as well, let it be added, and then you can make the modifications to it if you want.

You can take these up-for-grab issues or create your own @pandeyji711

@pandeyji711
Copy link
Contributor Author

pandeyji711 commented Aug 4, 2024

@Rakesh9100 till now no pr is created for pagination , and no pagination is avilable on website

@pandeyji711
Copy link
Contributor Author

@Rakesh9100 please merge my pr

@Rakesh9100
Copy link
Owner

You can check that it is added, and you can do the enhancements if you want to the existing one @pandeyji711

@pandeyji711
Copy link
Contributor Author

You can check that it is added, and you can do the enhancements if you want to the existing one @pandeyji711

@Rakesh9100 my pagination theam is better in look and fit in website theam,
and it has input featue that directly redirect to prefered page

@Rakesh9100
Copy link
Owner

But you have shown good image in issue, but the implementation is simple, why is it so @pandeyji711

@pandeyji711
Copy link
Contributor Author

But you have shown good image in issue, but the implementation is simple, why is it so @pandeyji711

@Rakesh9100 sorry , I does't understand what you said

@Rakesh9100
Copy link
Owner

@pandeyji711 You UI is different from what you've specified in issue?

image

About this? @pandeyji711

@pandeyji711
Copy link
Contributor Author

@pandeyji711 You UI is different from what you've specified in issue?
image

About this? @pandeyji711

@Rakesh9100
yes becouse that ui is not matching with the theam of website

@Rakesh9100 Rakesh9100 changed the title impilented pagination on homepage Implemented pagination on the website Dec 2, 2024
@Rakesh9100 Rakesh9100 removed the status: standby ✊ This issue is on hold label Dec 2, 2024
@Rakesh9100 Rakesh9100 closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Implementation of pagination on the website
3 participants