MiKo_1401 relaxed for questionable CleanArchitecture naming convention #949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not agree with the namespace separation done by projects claiming to follow the Clean architecture.
They propose to separate based on type kinds (such as controllers, interfaces, events, exceptions, classes, etc.)
In my opinion the focus is placed wrong here. Instead they should more focus on features. With the focus above the different types are placed together, so all controllers in a single namespace, all interfaces in another one, events in a different one etc.
In my opinion interfaces, events, exceptions, controllers, domain entities etc. should be separated based on the functionality.
So in case an interface defines a method that shall throw an exception or raise an event, those specific exceptions and events should be placed within the same namespace as the interface. However, the namespace should neither be named "interface", "exception" nor "event"; instead it should be named based on the functionality to accomplish.
However, some still follow the imho wrong pattern of separating by type kinds, thus MiKo_1401 should be relaxed a bit.