Reload weather icon sprite on MoveDescription close

[walshyb]

Issue

Per #905:

• pulling up a move description doesn't redraw the weather icon until you go back to the main battle menu
• if there's a weather condition and you're out of moves, the "has no moves left" message appears under the weather icon

Move Description Issue Before Example

2024-08-07.22-57-56.mov

Move Description Fixed Example

2024-08-07.23-00-56.mov

No Moves Left Issue Fixed Example

2024-08-12.02-13-33.mov

I'm not sure how testing / validation works for this. Please let me know if I'm missing anything, thank you!

[vulcandth]

Thanks! This looks good; probably leave this open until I can do some quick testing myself and I can possibly add the fix for if there's a weather condition and you're out of moves, the "has no moves left" message appears under the weather icon into this PR as well. I should have time to do that either tonight, or this weekend.

[walshyb]

Totally, thank you so much! If I have some time I'll see if I can figure out that other issue. But it's also fine if you get to it first!

[walshyb]

@vulcandth I think I got it working! Seems so at least when I tested.

Notes / questions:

• Had to change the jr .start_over to jp .start_over because having the LoadWeatherIconSprite call in .pressed_start and the ClearSprites call in .struggle gave me: jr target must be between -128 and 127 bytes away, not -129; use jp instead
• Haven't when an enemy pokemon uses struggle; proabably worth testing to ensure no regression
• Do you think that's a good place to call ClearSprites?
• Not shown in the vid, but I confirmed that the first fix still works. Also confirmed that weather icon is redrawn appropriately at start of next turn

Here's the vid:

2024-08-12.02-13-33.mov