Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path sanitation for absolute Windows paths. #10097

Merged

Conversation

tailoric
Copy link
Contributor

@tailoric tailoric commented Feb 5, 2025

When using an absolute Windows path (e.g. C:\Users\USER\Documents\) for the newbot command the translation table replaced the valid : character in the drive causing it to create the directory at the wrong place.

Fixes #10096

Summary

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

When using an absolute Windows path (e.g. `C:\Users\USER\Documents\`)
for the `newbot` command the translation table replaced the valid `:`
character in the drive causing it to create the directory at the wrong
place.

Fixes Rapptz#10096
@Rapptz Rapptz merged commit 52967ec into Rapptz:master Feb 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

directory is not used.
2 participants