-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a controls widget #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, please see comments
alexhroom
commented
Aug 28, 2024
Closed
alexhroom
force-pushed
the
7-control-widget
branch
2 times, most recently
from
September 4, 2024 06:39
2f6fdb6
to
b7788a6
Compare
StephenNneji
approved these changes
Sep 4, 2024
alexhroom
force-pushed
the
7-control-widget
branch
from
September 4, 2024 09:44
aecdb61
to
2113b7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7 by adding a Controls widget to the MDI. In particular:
editControls
command for undoable edits to the Controls objectMainWindowPresenter
ControlsWidget
andFitSettingsWidget
subwidget for the controls interfaceEnumDelegate
andBoolDelegate
, unused item delegates which will be used later for the Project tabValidatedInputWidget
which generates a value input field from Pydantic field infoAdaptiveDoubleSpinBox
featuring adaptive decimal places and scientific notationNote there is currently one workaround in here - resampleParams is not listed in the widget until we have decided on what to do about RascalSoftware/python-RAT#69
See below screenshots of the widget when running and not running. When running, the areas to edit the
Controls
object are greyed out so that it cannot be edited during a run. If there are invalid fit settings, trying to run will produce an error message telling the user which fit settings are invalid.