Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for strategy enum bug #50

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

StephenNneji
Copy link
Contributor

After my previous PR, runs are failing at controls.strategy = int(input_controls.strategy) because we are using vars(self.controls).update(new_values) to set the control the enum string is not converted to an enum. This fix ensures an enum is always passed out of the controls widget.

Might be worth fixing this in python-RAT so it does not fail if strategy is a string

@StephenNneji StephenNneji marked this pull request as ready for review October 30, 2024 10:37
Copy link
Collaborator

@alexhroom alexhroom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! the userData parameter of addItem is neat, i didn't know that existed

@StephenNneji StephenNneji changed the title Fixes for strategy enum bug Fix for strategy enum bug Oct 31, 2024
@StephenNneji StephenNneji merged commit c42f433 into RascalSoftware:main Oct 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants