-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plotting widget #55
Add plotting widget #55
Conversation
9739c60
to
ac0eafa
Compare
ac0eafa
to
bac34ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good and works great, mostly just documentation changes needed. some wider points:
-
at least for now while plotting is slow, it would be good to be able to toggle live plotting on or off as it drastically slows down the run!
-
this is minor but it would also be nice if we could use a consistent name for the plotting: we currently have
view.terminal_widget
holds aTerminalWidget
found interminal.py
view.project_widget
holds aProjectWidget
found inproject.py
view.controls_widget
holds aControlsWidget
found incontrols.py
but
view.plotting_widget
holds aPlotWidget
found inplotter.py
i think it'd be less complex for dev cognitive load if it could consistently be eitherplotting
,plot
orplotter
|
8b2f386
to
cfae20d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah sorry i forgot about updatePlotFreq
! looks good to me
super().__init__(parent)
from the mdi widgets to avoid the issue I was experiencing on Windows 11 where the widget gets added to theMainwindow
, it turns out the widgets are reparented when we added them to the mdi area so setting the initial parent was not needed.