Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plotting widget #55

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

StephenNneji
Copy link
Contributor

@StephenNneji StephenNneji commented Nov 6, 2024

  • Adds plot widget Closes Create plotting widget #30
  • Move saving of result to a command
  • I also removed parents i.e. super().__init__(parent) from the mdi widgets to avoid the issue I was experiencing on Windows 11 where the widget gets added to the Mainwindow, it turns out the widgets are reparented when we added them to the mdi area so setting the initial parent was not needed.

@StephenNneji StephenNneji force-pushed the add_plotting_widget branch 4 times, most recently from 9739c60 to ac0eafa Compare November 6, 2024 17:53
@StephenNneji StephenNneji marked this pull request as ready for review November 6, 2024 18:04
Copy link
Collaborator

@alexhroom alexhroom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and works great, mostly just documentation changes needed. some wider points:

  • at least for now while plotting is slow, it would be good to be able to toggle live plotting on or off as it drastically slows down the run!

  • this is minor but it would also be nice if we could use a consistent name for the plotting: we currently have
    view.terminal_widget holds a TerminalWidget found in terminal.py
    view.project_widget holds a ProjectWidget found in project.py
    view.controls_widget holds a ControlsWidget found in controls.py
    but
    view.plotting_widget holds a PlotWidget found in plotter.py
    i think it'd be less complex for dev cognitive load if it could consistently be either plotting, plot or plotter

rascal2/ui/model.py Outdated Show resolved Hide resolved
rascal2/core/commands.py Outdated Show resolved Hide resolved
rascal2/core/commands.py Outdated Show resolved Hide resolved
rascal2/core/commands.py Outdated Show resolved Hide resolved
rascal2/core/commands.py Outdated Show resolved Hide resolved
rascal2/core/commands.py Outdated Show resolved Hide resolved
rascal2/ui/model.py Show resolved Hide resolved
rascal2/ui/presenter.py Outdated Show resolved Hide resolved
@StephenNneji
Copy link
Contributor Author

  • I have renamed the plotting to plot
  • As for stopping the live plot you can set the updatePlotFreq in controls to zero.

Copy link
Collaborator

@alexhroom alexhroom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry i forgot about updatePlotFreq! looks good to me

@StephenNneji StephenNneji merged commit f9b5964 into RascalSoftware:main Nov 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create plotting widget
2 participants