Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nifty raven mineable assets patch 1.1 #1254

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NiftyRaven
Copy link

  • Revised new RPC command issuemineable to support the creation and distribution of mineable assets.

This commit introduces a standardized pull request template to the repository. The template aims to streamline the process of submitting pull requests by ensuring that all necessary information is provided upfront, which facilitates a more efficient and effective review process. Key components of the template include:

- Checklist for commit message adherence, test addition, documentation updates, and code linting.
- Detailed sections for describing the type of change, current and new behavior, and any breaking changes.
- Guidance for prefacing pull request titles with relevant areas such as Build, Consensus, GUI, Net, and more.
- Instructions for contributors to label work-in-progress (WIP) pull requests and include justification and reasoning for their changes.
- Emphasis on focused patchsets, with separate sections for features, refactoring, and decision-making processes.
- Detailed peer review guidelines and an explanation of the project's philosophy on pull requests.

This addition aligns with the project's commitment to maintaining high-quality contributions and providing clear guidance to contributors. The template will be automatically applied to all new pull requests, ensuring consistency and thoroughness across the project.
- Added new RPC command `issuemineable` to support the creation and distribution of mineable assets.
- Added new RPC command `issuemineabletestrun` to simulate mineable asset issuance and calculate costs and distribution timeframe.
- Included new commands in the RPC command table under the "mineable" category.
- Revised/Completed new RPC command `issuemineable` to support the creation and distribution of mineable assets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant