Skip to content
This repository has been archived by the owner on Jun 16, 2020. It is now read-only.

Using vdom-to-html doesn't work (returns empty string) #192

Closed
sekoyo opened this issue Oct 18, 2015 · 6 comments
Closed

Using vdom-to-html doesn't work (returns empty string) #192

sekoyo opened this issue Oct 18, 2015 · 6 comments

Comments

@sekoyo
Copy link

sekoyo commented Oct 18, 2015

Hi, using node v4.2.1 and vdom-to-html with mercury doesn't work.

Don't know if this is related but I noticed that:
require('virtual-dom/vnode/vnode'); // works
require('vtree/vnode'); // doesn't work

For example:

var toHTML = require('vdom-to-html');
var h = require('mercury').h;
toHTML(h('p', 'Hello')); // Returns nothing

Am I missing something obvious? Thanks

@danielnaab
Copy link
Contributor

@dominictobias: vdom-to-html uses virtual-dom 2.0.0 while Mercury depends on 1.3.0, and v2 has breaking changes. You can make your own local mercury.js with dependencies on ^2.0.0, or just import the virtual-dom dependencies directly. Either way, you'll want to depend on just one version, so your build artifact doesn't duplicate code.

@sekoyo
Copy link
Author

sekoyo commented Oct 18, 2015

Thanks I'll just use 1.2.5 @ vdom-to-html

@sekoyo sekoyo closed this as completed Oct 18, 2015
@gcallaghan
Copy link
Contributor

Is there any plan to move Mercury to virtual-dom 2.x ?

@panthershark
Copy link

If there is a list of things that need to be done to upgrayedd mercury, I'll be happy to chip in and knock some of them out.

Please let me know how I can help.

@crabmusket
Copy link
Contributor

Same here, I'd be happy to take on some work related to this.

@DeepAnchor
Copy link

I'd love to see this project advance, especially in regards to some of the points mentioned in the standing challenges thread -the most crucial of which I think is the having a formal component interface for people to design reusable components around.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants