New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some unsoundness issues #541

Merged

Raytwo merged 2 commits into Raytwo:master from liamwhite:safety

Aug 16, 2023

Contributor

liamwhite commented Aug 15, 2023 •

edited

Loading

The subtraction and addition of folder_offsets in extensions.rs intentionally overflows, twice. This was changed to the wrapping_ version of this operation.
vectors obtained from the game may have a nullptr __begin_ if they are zero-sized. Constructing zero-sized slices with a null pointer (happens during make_addition_context()) is unsound, so a branch was added to handle the case of a zero-sized vector.


          Fix some unsoundness issues

0e93b57

itsmeft24 approved these changes

View reviewed changes


          Merge branch 'master' into safety

00d6f53

Raytwo approved these changes

View reviewed changes

Raytwo merged commit 696e28c into Raytwo:master

1 check failed

Owner

Raytwo commented Aug 16, 2023

Appreciate it, thanks!

liamwhite deleted the safety branch

August 16, 2023 15:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet