NW6 | Fikret Ellek | React-Module-Project | Week-4 | Feature Validate AddBooking #63
Conversation
✅ Deploy Preview for cyf-react-hotel-project ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| return true; | ||
| } | ||
| }; | ||
|
|
||
| const handleSubmit = (e) => { |
There was a problem hiding this comment.
Brilliant calling validateBooking function inside the handleSubmit function.
| if (!isNaN(parseInt(formData.firstName))) { | ||
| alert("Enter a valid name"); | ||
| } else if (!isNaN(parseInt(formData.surname))) { | ||
| alert("Enter a valid surname"); |
There was a problem hiding this comment.
This is an intresting approach to the problem. I think it mostly works, even for special letters such as Ö which is good as few validation solutions do. Of course it includes ! and other special chars
There was a problem hiding this comment.
as you said regex would cover it all. to get a valid name should I use [a-zA-z]?
| formData.email.includes(".") && | ||
| formData.email.indexOf("@") === formData.email.lastIndexOf("@") && | ||
| formData.email.indexOf("@") < formData.email.lastIndexOf(".") | ||
| ) |
There was a problem hiding this comment.
This works but it's fairly hard to read I normally use a regex in these cases but that is a diffrent thing. A fairly simple regex such as formData.email.match(/^.+@.+.$/)) should work
| } else if (!(formData.roomId > 0 && formData.roomId < 100)) { | ||
| alert("Enter a valid roon id"); | ||
| } else if (!(formData.checkInDate < formData.checkOutDate)) { | ||
| alert("Enter valid dates"); |
There was a problem hiding this comment.
Good work, a more specfic error message here would be helpful to the user though - doesn't say which date is invalid
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.