Skip to content

Commit

Permalink
Merge pull request #396 from Rblp/bugfix/bsrch
Browse files Browse the repository at this point in the history
Correct request formation, add working example
  • Loading branch information
johnlaing authored Sep 6, 2024
2 parents 882e546 + 56bf87c commit 890fb5f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion R/bsrch.R
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
##' works on user-defined searches accessed via SRCH.
##' @examples
##' \dontrun{
##' head(bsrch("FI:YOURSRCH"), 20)
##' head(bsrch("FI:SRCHEX.@CLOSUB"), 20)
##' }
bsrch <- function(domain,
limit="",
Expand Down
2 changes: 1 addition & 1 deletion man/bsrch.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/bsrch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ DataFrame bsrch_Impl(SEXP con,
Service exrService = session->getService(exrsrv.c_str());
Request request = exrService.createRequest("ExcelGetGridRequest");

request.getElement(Name{"Domain"}).setValue(Name{domain.c_str()});
request.getElement(Name{"Domain"}).setValue(domain.c_str());

// TODO - implement limit and other overrides

Expand Down

0 comments on commit 890fb5f

Please sign in to comment.