feat: prereleases #1653
Draft
feat: prereleases #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminHalko
added
the
ReVanced Manager Compose
Axelen123
requested changes
Mar 29, 2024
|
|
||
| - name: Add hash to APK | ||
| run: mv app/build/outputs/apk/release/app-release.apk revanced-manager-${{ env.COMMIT_HASH }}.apk | ||
| run: ./gradlew assembleRelease --no-daemon -PnoProguard -Psuffix=${{ steps.get_commit_hash.outputs.hash }} |
Ushie
reviewed
Nov 6, 2024
| versionCode = 1 | ||
| versionName = "0.0.1" | ||
| versionName = project.version.toString() | ||
| versionCode = (majorVersion.toInt() * 100000000) + (minorVersion.toInt() * 100000) + (patchVersion.toInt() * 100) + devVersion.toInt() |
There was a problem hiding this comment.
ReVanced Manager v2 will not use the versionCode calculator that v1 uses, it was a mistake to implement that
The right way is to bump by 1 for each build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pre-release support to compose builds. Won't be used until compose manager reaches the
devbranch.I have verified that it works here and here.