fix bug with normalization of transitory sensitivities with interfaces #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisBNEU can you test if this solves your problem? |
mjohnson541
force-pushed
the
fix_transitorysens_interfaces
branch
from
e5e0c9a to
b61fe28
Compare
hwpang
reviewed
Nov 14, 2023
src/TransitorySensitivities.jl
Outdated
| @@ -163,6 +163,11 @@ function normalizefulltransitorysensitivities!(dSdt,ssys::SystemSimulation,t) | |||
| @views ns = y[sim.domain.indexes[1]:sim.domain.indexes[2]] | |||
| @views dSdt[sim.domain.indexes[1]:sim.domain.indexes[2],:] ./= ns | |||
| end | |||
| for (i,inter) in enumerate(ssys.interfaces) | |||
| if isa(inter,AbstractReactiveInternalInterface) | |||
There was a problem hiding this comment.
Can you add blank after comma
hwpang
reviewed
Nov 14, 2023
src/TransitorySensitivities.jl
Outdated
Comment on lines
211
to
212
| for (i,inter) in enumerate(ssys.interfaces) | ||
| if isa(inter,AbstractReactiveInternalInterface) |
There was a problem hiding this comment.
Can you add blanks after the commas here
hwpang
reviewed
Nov 14, 2023
src/TransitorySensitivities.jl
Outdated
Comment on lines
186
to
190
| dSdt .*= ssys.p[ind] | ||
| for sim in ssys.sims | ||
| if sim.domain.parameterindexes[1]+length(sim.species) < ind && sim.domain.parameterindexes[2] > ind | ||
| dSdt .*= ssys.p[ind] | ||
| end | ||
| @views ns = y[sim.domain.indexes[1]:sim.domain.indexes[2]] |
There was a problem hiding this comment.
Should revert this because we should only apply this correction to rate. The old way of implement will only happen once if the ind is within the particular simulation.
mjohnson541
force-pushed
the
fix_transitorysens_interfaces
branch
from
b61fe28 to
b3d12d8
Compare
mjohnson541
force-pushed
the
fix_transitorysens_interfaces
branch
from
b3d12d8 to
be40355
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
- Coverage 49.70% 49.65% -0.05%
==========================================
Files 31 31
Lines 8138 8146 +8
==========================================
Hits 4045 4045
- Misses 4093 4101 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #223