-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SquareButtonGrouppo #85
Conversation
Assert.assertFalse(toggleThree.isToggled()); | ||
Assert.assertFalse(nonToggled.isToggled()); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be good to add an additional test to ensure that if you click the same button twice, it's still toggled. That was the original problem that brought up the SquareButtonGroup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I can do that. It works in the example, but I can check it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I saw that. The example looks to do exactly what I was hoping. Good to enforce that behavior in the test, too.
Looks like the integTest isn't happy with Note that because of #68 you might have to hide the dock if it's at the bottom of your screen. |
@ezweave have all the comments been addressed on this PR? if so, let's merge. |
Done. |
Now it will magically handle your toggles for you! I may have to tweak a little but take a look.