Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SquareButtonGrouppo #85

Merged
merged 7 commits into from
Jan 27, 2014
Merged

SquareButtonGrouppo #85

merged 7 commits into from
Jan 27, 2014

Conversation

ezweave
Copy link
Contributor

@ezweave ezweave commented Jan 21, 2014

Now it will magically handle your toggles for you! I may have to tweak a little but take a look.

Assert.assertFalse(toggleThree.isToggled());
Assert.assertFalse(nonToggled.isToggled());
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to add an additional test to ensure that if you click the same button twice, it's still toggled. That was the original problem that brought up the SquareButtonGroup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I can do that. It works in the example, but I can check it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I saw that. The example looks to do exactly what I was hoping. Good to enforce that behavior in the test, too.

@blimmer
Copy link
Contributor

blimmer commented Jan 21, 2014

Looks like the integTest isn't happy with Testcase: testBasicToggle. That's what's causing the Travis failure. I am able to reproduce this on my machine by running Gradle's integTest task from the command line.

Note that because of #68 you might have to hide the dock if it's at the bottom of your screen.

@blimmer
Copy link
Contributor

blimmer commented Jan 27, 2014

@ezweave have all the comments been addressed on this PR? if so, let's merge.

ezweave added a commit that referenced this pull request Jan 27, 2014
@ezweave ezweave merged commit 0c80a43 into ReadyTalk:master Jan 27, 2014
@ezweave
Copy link
Contributor Author

ezweave commented Jan 27, 2014

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants