-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comments app #11
Merged
Merged
comments app #11
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
from django.contrib import admin | ||
|
||
from .models import Comment | ||
|
||
|
||
@admin.register(Comment) | ||
class CommentAdmin(admin.ModelAdmin): | ||
list_display = ("pk", "author", "text", "created_at") | ||
list_filter = ("author", "created_at") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
from django.apps import AppConfig | ||
|
||
|
||
class CommentsConfig(AppConfig): | ||
default_auto_field = "django.db.models.BigAutoField" | ||
name = "comments" | ||
verbose_name = "Комментарий" | ||
verbose_name_plural = "Комментарии" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
from django.db import models | ||
from ipr.models import IPR | ||
from task.models import Task | ||
from users.models import User | ||
|
||
from core.enums import Limits | ||
|
||
|
||
class Comment(models.Model): | ||
author = models.ForeignKey( | ||
User, | ||
related_name="comments", | ||
on_delete=models.CASCADE, | ||
verbose_name="Автор комментария", | ||
) | ||
ipr = models.ForeignKey( | ||
IPR, | ||
related_name="comments", | ||
on_delete=models.CASCADE, | ||
verbose_name="ИПР", | ||
) | ||
task = models.ForeignKey( | ||
Task, | ||
related_name="comments", | ||
on_delete=models.CASCADE, | ||
verbose_name="Задача", | ||
) | ||
|
||
text = models.TextField( | ||
verbose_name="Комментарий", | ||
max_length=Limits.MAX_LEN_COMMENT_TEXT, | ||
) | ||
|
||
created_at = models.DateField( | ||
auto_now_add=True, | ||
verbose_name="Дата создания", | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
from enum import IntEnum | ||
|
||
|
||
class Limits(IntEnum): | ||
# Максимальная длина текстового поля комментария в приложении "comments" | ||
MAX_LEN_COMMENT_TEXT = (200,) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это что?
Какую задачу решает?
Почему
max_length
это не константа вsettings.py
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Коллекция перечислений.
Большой разницы нет, если не нужно перебирать или получить имя по значению.
Когда добавлял, ещё констант не было в settings.
Так код немного понятнее, на мой взгляд.
Импорт класса Limits более понятен, чем импорт settings и лаконичнее чем импорт констант из settings.
Удалю, перенесу константой в settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я вроде разобрался, интересное решение.
Я бы попробовал, но переносить константы из settings уже лениво.
В идеале такое должно быть установлено как правильно на старте проекта.
PS: А почему в
MAX_LEN_COMMENT_TEXT = (200,)
200 внутри кортежа?На первый взгляд должно быть
MAX_LEN_COMMENT_TEXT = 200
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
С кортежем, я ошибся.
Перенес константой в settings.