-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/cs/handle recoverable with filter #427
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The major change here is to the SQL we use to generate the message stream: SELECT
m.*,
c.chat_id,
(SELECT COUNT(*) FROM message_attachment_join a WHERE m.ROWID = a.message_id) as num_attachments,
d.chat_id as deleted_from,
(SELECT COUNT(*) FROM message m2 WHERE m2.thread_originator_guid = m.guid) as num_replies
FROM
message as m
LEFT JOIN chat_message_join as c ON m.ROWID = c.message_id
LEFT JOIN chat_recoverable_message_join as d ON m.ROWID = d.message_id
WHERE
(c.chat_id IN (1, 2, 3) OR d.chat_id IN (1, 2, 3))
ORDER BY
m.date; Previously, we used SELECT
m.*,
c.chat_id,
(SELECT COUNT(*) FROM MESSAGE_ATTACHMENT_JOIN a WHERE m.ROWID = a.message_id) as num_attachments,
(SELECT b.chat_id FROM RECENTLY_DELETED b WHERE m.ROWID = b.message_id) as deleted_from,
(SELECT COUNT(*) FROM MESSAGE m2 WHERE m2.thread_originator_guid = m.guid) as num_replies
FROM
message as m
LEFT JOIN CHAT_MESSAGE_JOIN as c ON m.ROWID = c.message_id
WHERE
c.chat_id IN (1, 2, 3)
ORDER BY
m.date; The salient difference is that we query for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
crate: cli
Related to the CLI crate
crate: database
Related to the database crate
table
Related to table data
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-s
,-e
, and/or-t
--conversation-filter
is set #426