Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cronjobs for sync APIs #64

Merged
merged 7 commits into from
Aug 13, 2024
Merged

Conversation

Pavangbhat
Copy link
Contributor

@Pavangbhat Pavangbhat commented Mar 26, 2024

Date: 26-03-2024

Developer Name: Pavan Bhat


Issue Ticket Number

#60

Improvements for this Pr are being tracked here

Description

As per the suggestions received from the last PR review, have made the changes needed
Changes:

  1. Created fireAndForgetApiCaller as we are not consuming any responses
  2. Reduced the number of corn triggers as we can only support five
  3. Renamed functions

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Test Coverage

image

Additional Notes

src/worker.ts Outdated Show resolved Hide resolved
@prakashchoudhary07 prakashchoudhary07 merged commit 58bb3cb into develop Aug 13, 2024
1 check passed
@prakashchoudhary07 prakashchoudhary07 deleted the refactor/sync-buttons branch August 13, 2024 22:28
@MehulKChaudhari MehulKChaudhari mentioned this pull request Aug 14, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants