This repository has been archived by the owner on Mar 1, 2025. It is now read-only.
removed feature flag from accordian and invalid date #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shubhamsinghbundela
approved these changes
Oct 26, 2023
Achintya-Chatterjee
approved these changes
Oct 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #569
What is the change?
Removal of feature flag from 2 bug fixes related to below merged MR.
#561
#565
Is it bug?
No
NA
*Dev Tested?
*Tested on:
Platforms
Browsers
Before / After Change Screenshots
Before
It needed a feature flag for below scenario
After - without need of feature flag.
Scenario 1: Invalid Date
Scenario 2: Expanding accordian section with no data)
Test results:
