[My Site Migration] feat: add discord route #982
Merged
+151
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying www-rds with
|
| Latest commit: |
0a8430c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c1391a2c.www-rds.pages.dev |
| Branch Preview URL: | https://feat-discord-page.www-rds.pages.dev |
tejaskh3
changed the title
Achintya-Chatterjee
previously approved these changes
Jan 16, 2025
iamitprakash
requested changes
Jan 17, 2025
tejaskh3
commented
Jan 17, 2025
joyguptaa
previously approved these changes
Jan 17, 2025
Achintya-Chatterjee
previously approved these changes
Jan 17, 2025
yesyash
requested changes
Jan 18, 2025
app/utils/redirect-auth.js
Outdated
Comment on lines
3
to
10
| export default function () { | ||
| let authUrl = AUTH.GITHUB_SIGN_IN; | ||
| if (typeof window !== 'undefined') { | ||
| const separator = authUrl.includes('?') ? '&' : '?'; | ||
| authUrl = `${authUrl}${separator}redirectURL=${encodeURIComponent(window.location.href)}`; | ||
| } | ||
| window.open(authUrl, '_self'); | ||
| } |
There was a problem hiding this comment.
- change this function to a named export.
- can we use
UrlSearchParamsto handle search params instead of doingauthUrl.includes('?') ? '&' : '?';? - can we use
window.location.hrefinstead of window.open?
tejaskh3
dismissed stale reviews from Achintya-Chatterjee and joyguptaa
via
0a8430c
iamitprakash
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 17 January, 2025
Developer Name: Tejasgp
Description:
This PR introduces the integration of Discord account linking functionality. The following updates have been made:
Key Features:
Issue Ticket Number:
/discordVerification Page #592Pending Work:
discord.hbsin future PRs.Is Under Feature Flag:
Database Changes:
Breaking Changes:
Is Development Tested?