This repository has been archived by the owner on Mar 13, 2019. It is now read-only.
added room info command #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealDolos
suggested changes
May 16, 2017
requirements.txt
Outdated
| @@ -1,7 +1,7 @@ | |||
| isodate>=0.5.1 | |||
| python-dateutil>=2.4.2 | |||
| requests>=2.7.0 | |||
| volapi>=5.0.0 | |||
| volapi>=5.1.1 | |||
There was a problem hiding this comment.
Make it 5.2.0 because new feature
volaparrot/_version.py
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| __all__ = ["__version__", "__title__", "__fulltitle__"] | |||
|
|
|||
| __version__ = "3.0" | |||
| __version__ = "3.1" | |||
There was a problem hiding this comment.
don't mess with version in feature commits
volaparrot/extracommands/roominfo.py
Outdated
| return True | ||
| RoomInfoCommand.last_check = time() | ||
| info = [] | ||
| info += "{:>20}: {}".format("Owner", self.conf_key("owner")), |
There was a problem hiding this comment.
if you want a shorthand of self.room.config just do config = self.room.config and use that. do not add a method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uploads info text file to the room. I made this because I see people asking about who is room owner constantly.
Also I think it would be sensible to add
ownercolumn to rooms table in phrases2.db since vola config have owner field now. I will try to make that.