Aait.bac.g2a.fikremariam.allfeatures #267

fikreanteneh · 2023-08-25T20:15:38Z

No description provided.

abrahamshimekt · 2023-08-27T13:09:52Z

...ckend/group-2A/Application/Features/Comment/Handlers/Commands/UpdateCommentCommandHandler.cs

        var validationResult = await validator.ValidateAsync(request.UpdateCommentDto);
-
+        Console.WriteLine(request.UpdateCommentDto);


remove this line:
Console.WriteLine(request.UpdateCommentDto);

abrahamshimekt · 2023-08-27T13:10:16Z

...ckend/group-2A/Application/Features/Comment/Handlers/Commands/UpdateCommentCommandHandler.cs

@@ -21,11 +21,13 @@ public UpdateCommentCommandHandler(IUnitOfWork unitOfWork, IMapper mapper)
    public async Task<Unit> Handle(UpdateCommentCommand request, CancellationToken cancellationToken)
    {
        var validator = new UpdateCommentDtoValidator(_unitOfWork.commentRepository);
+        Console.WriteLine("reached handler");


remove this line :
Console.WriteLine("reached handler");

abrahamshimekt · 2023-08-27T13:11:26Z

...ckend/group-2A/Application/Features/Comment/Handlers/Commands/UpdateCommentCommandHandler.cs

-        {
-            throw new ValidationException(validationResult.Errors);
+        {    
+            Console.WriteLine("validation");


remove :
Console.WriteLine("validation");

abrahamshimekt · 2023-08-27T13:14:16Z

...ckend/group-2A/Application/Features/Comment/Handlers/Commands/UpdateCommentCommandHandler.cs

-            throw new ValidationException(validationResult.Errors);
+        {    
+            Console.WriteLine("validation");
+            throw new Exception();


please specify the exception type.

abrahamshimekt · 2023-08-27T13:15:17Z

aait/backend/group-2A/Application/Features/Like/Handlers/Commands/DeleteLikeCommandHandler.cs

@@ -19,6 +19,7 @@ public DeleteLikeCommandHandler(IUnitOfWork unitOfWork, IMapper mapper)

        public async Task<Unit> Handle(DeleteLikeCommand request, CancellationToken cancellationToken)
        {
+            Console.WriteLine("-------------------$");


remove : Console.WriteLine("-------------------$");

abrahamshimekt · 2023-08-27T13:16:14Z

aait/backend/group-2A/Application/Features/Like/Handlers/Commands/DeleteLikeCommandHandler.cs

@@ -19,6 +19,7 @@ public DeleteLikeCommandHandler(IUnitOfWork unitOfWork, IMapper mapper)

        public async Task<Unit> Handle(DeleteLikeCommand request, CancellationToken cancellationToken)
        {
+            Console.WriteLine("-------------------$");
             await _unitOfWork.likeRepository.UnlikePost(_mapper.Map<Domain.Entities.Like>(request.like));
             await _unitOfWork.Save();


check change was made in the db

abrahamshimekt · 2023-08-27T13:18:29Z

aait/backend/group-2A/Application/Features/Like/Handlers/Queries/GetLikedPostRequestHandler.cs

+    }
+
+    public async Task<List<PostDto>> Handle(GetLikedPostRequest request, CancellationToken cancellationToken){
+        var posts = await _unitOfWork.likeRepository.GetLikedPost(request.Id);


Check whether the posts list is null or empty before mapping it. null pointer exception will be thrown if you try to map a null. change you query and queryHandler

abrahamshimekt · 2023-08-27T13:26:06Z

aait/backend/group-2A/Application/Features/Like/Handlers/Queries/GetLikedPostRequestHandler.cs

+    private readonly IMapper _mapper;
+
+    public GetLikedPostRequestHandler(IUnitOfWork unitOfWork, IMapper mapper){
+        _unitOfWork = unitOfWork;


remove unit of work injection

abrahamshimekt · 2023-08-27T13:28:34Z

aait/backend/group-2A/Application/Features/Like/Handlers/Queries/GetLikedPostRequestHandler.cs

+
+namespace Application.Features.Like.Handlers.Query;
+
+public class GetLikedPostRequestHandler : IRequestHandler<GetLikedPostRequest, List<PostDto>>{


if you want a liked post from likeRepository wtih post id , the dto you're gonna return is not a list of postDto

abrahamshimekt · 2023-08-27T13:30:07Z

aait/backend/group-2A/Application/Features/Post/Handlers/Command/DeletePostCommandHandler.cs

-            // throw Exception("Post Not Found");
+
+        if (post == null || post.UserId != request.UserId){
+            throw new Exception("You Don't Have Access");
        }
        await _unitOfWork.postRepository.Delete(post);
        await _unitOfWork.Save();


check whether the db was actually affected

abrahamshimekt · 2023-08-27T13:33:48Z

aait/backend/group-2A/Application/Features/User/Handlers/Commands/CreateUserCommand.cs

                throw new ValidationException(validationResult);
            }
            var user = _mapper.Map<Domain.Entities.User>(request.CreateUser);
            await _unitOfWork.userRepository.Add(user);
+            Console.WriteLine("reached Here");


remove : Console.WriteLine("reached Here"); don't push print codes to remote repository. remove them once you're ready to push to remote repo.

abrahamshimekt · 2023-08-27T13:36:06Z

aait/backend/group-2A/Application/Features/User/Handlers/Commands/CreateUserCommand.cs

                throw new ValidationException(validationResult);
            }
            var user = _mapper.Map<Domain.Entities.User>(request.CreateUser);
            await _unitOfWork.userRepository.Add(user);
+            Console.WriteLine("reached Here");
+            var token = await _authService.Register(request.CreateUser, _unitOfWork.userRepository);
+            Console.WriteLine("---------------AuthServise");


remove:
Console.WriteLine("---------------AuthServise");

abrahamshimekt · 2023-08-27T13:36:34Z

aait/backend/group-2A/Application/Features/User/Handlers/Commands/CreateUserCommand.cs

+            var token = await _authService.Register(request.CreateUser, _unitOfWork.userRepository);
+            Console.WriteLine("---------------AuthServise");
+            if (token is null){
+                throw new Exception();


tell the exception type that was thrown

abrahamshimekt · 2023-08-27T13:36:59Z

aait/backend/group-2A/Application/Features/User/Handlers/Commands/CreateUserCommand.cs

+            if (token is null){
+                throw new Exception();
+            }
+
            await _unitOfWork.Save();


check if the user was created in the db

abrahamshimekt · 2023-08-27T13:39:18Z

aait/backend/group-2A/Application/Features/User/Handlers/Commands/UpdateUserCommand.cs

            var user = await _unitOfWork.userRepository.Get(request.updateUser.Id);
            _mapper.Map(request.updateUser, user);
-            // var user = _mapper.Map<Domain.Entities.User>(request.updateUser);
+            if (await _authService.Update(request.updateUser, user.Email)){
+                throw new Exception("Can't be Comleted");


tell the exception type

abrahamshimekt · 2023-08-27T13:39:58Z

aait/backend/group-2A/Application/Features/User/Handlers/Commands/UpdateUserCommand.cs

+                throw new Exception("Can't be Comleted");
+
+            }
+            user = _mapper.Map<Domain.Entities.User>(request.updateUser);
            await _unitOfWork.userRepository.Update(user);
            await _unitOfWork.Save();


check whether the user was updated or not

abrahamshimekt · 2023-08-27T13:40:34Z

aait/backend/group-2A/Application/Features/User/Handlers/Queries/GetUserProfileHandler.cs

+    public async Task<UserProfileDTO> Handle(GetUserProfile request, CancellationToken cancellationToken){
+        var user = await _unitOfWork.userRepository.Get(request.Id);
+        if (user is null){
+            throw new Exception("Not Found");


tell the exception type to be thrown

abrahamshimekt · 2023-08-27T13:42:01Z

aait/backend/group-2A/Application/Features/User/Handlers/Queries/GetUsersHandler.cs

+
+    public async Task<List<UserDto>> Handle(GetUsers request, CancellationToken cancellationToken){
+        var user = await _unitOfWork.userRepository.GetAll();
+        return _mapper.Map<List<UserDto>>(user);


change the variable user to users and check it if it is null or empty

abrahamshimekt · 2023-08-27T13:43:08Z

aait/backend/group-2A/Application/Features/User/Handlers/Queries/LoginHandler.cs

+
+    public async Task<AuthResponse> Handle(Login request, CancellationToken cancellationToken){
+        Console.WriteLine("------------Started");
+        var token = await _authService.Login(new AuthRequest(){


remove: Console.WriteLine("---------------AuthServise");

abrahamshimekt · 2023-08-27T13:44:42Z

aait/backend/group-2A/Application/Features/User/Handlers/Queries/LoginHandler.cs

+
+    public LoginHandler(IUnitOfWork unitOfWork, IMapper mapper, IAuthService authService)
+    {
+        _mapper = mapper; 


remove the mapper

abrahamshimekt · 2023-08-27T13:49:58Z

aait/backend/group-2A/Infrastructure/Migrations/20230824113612_Initial Migration 2.cs

@@ -0,0 +1,223 @@
+using System;


never push migration files. delete them before pushing.

abrahamshimekt · 2023-08-27T13:50:33Z

aait/backend/group-2A/Infrastructure/Service/AuthService.cs

+     {
+         var user = await _userManager.FindByEmailAsync(request.Email);
+         if (user is null){
+             Console.WriteLine("-------------------User Not Found ");


remove : Console.WriteLine("-------------------User Not Found ");

abrahamshimekt · 2023-08-27T13:54:09Z

aait/backend/group-2A/Infrastructure/Service/AuthService.cs

+             // throw new NotFoundException("Account",req.Email); 
+         }
+
+         var isCorrect = await _signInManager.PasswordSignInAsync(userName: user.UserName, request.Password,isPersistent:true, lockoutOnFailure:false);


change the isCorrect variable to something like loginResponse

abrahamshimekt · 2023-08-27T13:54:32Z

aait/backend/group-2A/Infrastructure/Service/AuthService.cs

+
+         var isCorrect = await _signInManager.PasswordSignInAsync(userName: user.UserName, request.Password,isPersistent:true, lockoutOnFailure:false);
+         if (!isCorrect.Succeeded){
+             Console.WriteLine("-------------------Creditial Not Found ");


remove : Console.WriteLine("-------------------Creditial Not Found ");

abrahamshimekt · 2023-08-27T13:54:55Z

aait/backend/group-2A/Infrastructure/Service/AuthService.cs

+             // throw new Exception($"invalid credentials for user: {request.Email}"); 
+         }
+
+         Console.WriteLine("-------------UseR Repository started");


remove:
Console.WriteLine("-------------UseR Repository started");

abrahamshimekt · 2023-08-27T13:57:15Z

aait/backend/group-2A/Infrastructure/Service/AuthService.cs

+
+         var customeUser = await userRepository.GetUserByEmail(user.Email);
+
+         Console.WriteLine("---------------OKKKKKKKKKKKKK  JWT");


remove: Console.WriteLine("---------------OKKKKKKKKKKKKK JWT");

abrahamshimekt · 2023-08-27T13:58:18Z

aait/backend/group-2A/Infrastructure/Service/AuthService.cs

+         Console.WriteLine("---------------OKKKKKKKKKKKKK  JWT");
+         JwtSecurityToken token = await GenerateToken(user, customeUser.Id.ToString());
+         var Token = new JwtSecurityTokenHandler().WriteToken(token);
+         Console.WriteLine("---------------OKKKKKKKKKKKKK  JWT");


remove : Console.WriteLine("---------------OKKKKKKKKKKKKK JWT");

abrahamshimekt · 2023-08-27T14:01:42Z

aait/backend/group-2A/Infrastructure/Service/AuthService.cs

+         var alreadyExist = await _userManager.FindByEmailAsync(req.Email); 
+         if (alreadyExist is not null){
+             Console.WriteLine("----Email Exist");
+             return null;


if user already exist , email already exist error has to thrown

abrahamshimekt · 2023-08-27T14:03:32Z

aait/backend/group-2A/Infrastructure/Service/AuthService.cs

+         var creatingUser = await _userManager.CreateAsync(user, req.Password);
+         if (!creatingUser.Succeeded){
+             Console.WriteLine("Create Error ---------------");
+             Console.WriteLine(creatingUser.ToString());


remove the print lines

abrahamshimekt · 2023-08-27T15:13:33Z

aait/backend/group-2A/Application/Model/string.cs

@@ -0,0 +1,8 @@
+namespace Application.Model;
+
+public class @string{


it is generally recommended to use meaningful and descriptive names that do not conflict with reserved keywords to improve code readability and maintainability.

abrahamshimekt · 2023-08-27T15:16:34Z

aait/backend/group-2A/Application/Features/User/Handlers/Commands/CreateUserCommand.cs

            await _unitOfWork.Save();
-            return user.Id;
+
+            return new AuthResponse(){ Id = user.Id, Email = user.Email, Username = user.UserName};


for registering the user you can return the Id of the user instead of the AuthResponse

abrahamshimekt · 2023-08-27T15:18:41Z

aait/backend/group-2A/Application/Features/User/Request/Commands/CreateUserCommand.cs

 using Domain;
 using MediatR;

 namespace Application.Features.User.Request.Commands
 {
-    public class CreateUserCommand : IRequest<int>
+    public class CreateUserCommand : IRequest<AuthResponse>


Here you can promise to return registration response like : public class RegistrationResponse
{
public string UserId { get; set; }
}

abrahamshimekt · 2023-08-27T15:32:34Z

aait/backend/group-2A/Application/Profiles/MappingProfile.cs

@@ -14,16 +14,16 @@ public class MappingProfile : AutoMapper.Profile

        CreateMap<Post, PostDto>().ReverseMap();
        CreateMap<Post, UpdatePostDto>().ReverseMap();
-        CreateMap<Post, CreateUserDTO>().ReverseMap();
+        CreateMap<Post, CreatePostDto>().ReverseMap();


if there is not scenario that you are going to map Entity to CreateEntityDto or UpdateEntityDto , map the creeateEntityDto or UpdateEntityDto to Entity. you don't need to reverseMap(). example
CreateMap<CreatePostDto,Post>();

abrahamshimekt · 2023-08-27T15:36:29Z

aait/backend/group-2A/Domain/Entities/Comment.cs

-        public required int CreatedAt{ get; set; }
-        public required int UpdatedAt{ get; set; }
+        public required DateTime CreatedAt{ get; set; }
+        public required DateTime UpdatedAt{ get; set; }


Instead of having CreatedAt and UpdateAt fields in the Comment, you can create a BaseEntity with Id, createdAt and updatedAt fields . Then make all of the Entities tracked in the database as an entry to extend from the base entity.

abrahamshimekt · 2023-08-27T15:41:40Z

aait/backend/group-2A/Domain/Entities/Comment.cs

@@ -8,8 +8,8 @@ public class Comment
        //The User That Commented
        public required int UserId { get; set; }


you can remove required keyword if you have validation for creating and updating

abrahamshimekt · 2023-08-27T15:43:06Z

aait/backend/group-2A/Domain/Entities/Comment.cs

-        public required int CreatedAt{ get; set; }
-        public required int UpdatedAt{ get; set; }
+        public required DateTime CreatedAt{ get; set; }
+        public required DateTime UpdatedAt{ get; set; }

        //Navigation Property
        public virtual User? User{ get; set; }


If there is no derived class from Comment, there won't be a class to override the virtual property . so you can remove the virtual keyword

abrahamshimekt · 2023-08-27T15:53:08Z

aait/backend/group-2A/Infrastructure/Service/AuthService.cs

+             return null;
+             // throw new Exception($"Failed to register \n"); 
+         } 
+         Console.WriteLine("User Registered");


remove: Console.WriteLine("User Registered");

abrahamshimekt · 2023-08-27T15:54:34Z

aait/backend/group-2A/Infrastructure/Service/AuthService.cs

+             // throw new Exception($"Failed to register \n"); 
+         } 
+         Console.WriteLine("User Registered");
+         AuthRequest request = new AuthRequest {Email = req.Email, Password = req.Password };


since you aren't using "AuthRequest request = new AuthRequest {Email = req.Email, Password = req.Password }; " delete

abrahamshimekt · 2023-08-27T16:08:08Z

aait/backend/group-2A/Persistence/Repositories/PostRepository.cs

@@ -18,6 +18,7 @@ public PostRepository(SocialSyncDbContext context) : base(context)
    }

    public async Task<List<Post>> GetBytag(string tag){
+        Console.WriteLine("");


remove the print line

abrahamshimekt · 2023-08-27T17:36:24Z

aait/backend/group-2A/WebApi/Controllers/UserController.cs

-        [HttpPost("register")]
-        public async Task<IActionResult> CreateUser(CreateUserDTO userDto)
+        [HttpPost("Register")]
+        public async Task<IActionResult> CreateUser( CreateUserDTO userDto)


To deserialize the JSON data from the request body and bind it to the CreateUserDTO object, you have to include [FromBody] to the CreateUser function.

abrahamshimekt · 2023-08-27T17:38:20Z

aait/backend/group-2A/WebApi/Controllers/UserController.cs

+        {
+            var command = new GetUserProfile() { Id = UserId };
+            var token = await _mediator.Send(command);
+            return Ok(token);


The getProfile Action must return the user details

abrahamshimekt · 2023-08-27T17:38:44Z

aait/backend/group-2A/WebApi/Controllers/UserController.cs

+        {
+            var command = new GetUsers();
+            var token = await _mediator.Send(command);
+            return Ok(token);


GetUsers function must return the list of users

abrahamshimekt · 2023-08-27T18:05:00Z

aait/backend/group-2A/WebApi/Controllers/PostController.cs

-    [HttpGet("{Search}")]
-    public async Task<IActionResult> GetByContent( string search)
+    [HttpGet]
+    public async Task<IActionResult> GetPosts([FromQuery] string? search, [FromQuery] string? tag)
    {


Since the search is by the content of the post or the tag it has, you should a separate command that contains two fields : example
public classs SearchCommand : IRequest<List>{
public string Content {get;set;}
public string Tag {get;set;}
}
create a handler for this command:
create a search method in your post repository that filers posts by content or tag:
the search you implemented is totally incorrect :let pick one simple example if the user pass content and tag to search , you code is not going to search posts that have the tag provided , because it just return the posts that contain the given content only.

instead of if else condition, a single command handler can make your life easier

abrahamshimekt · 2023-08-27T18:11:35Z

aait/backend/group-2A/WebApi/Controllers/PostController.cs

+
+
+    [HttpPut("{PostId}")]
+    public async Task<IActionResult> UpdatePost([FromBody] UpdatePostDto updatePost, int UserId, int PostId){


you don't need to pass the userId and PostId to updatePost Action , you can define them in UpdatePostDto as field.

abrahamshimekt · 2023-08-27T18:14:54Z

aait/backend/group-2A/WebApi/Controllers/LikeController.cs

+
+
+    [HttpPost("{PostId}")]
+    public async Task<ActionResult> AddLike( int PostId)


add [frombody] attribute to bind the postId from request body to postId paramater
whenever you use post or put ,please use frombody since the data is stored in the request body.

abrahamshimekt · 2023-08-27T18:26:15Z

aait/backend/group-2A/WebApi/Controllers/FollowController.cs

+        }
+
+        [HttpPost("follow/{UserId}")]
+        public async Task<IActionResult> Follow(int UserId)


add frombody

abrahamshimekt

Resolve the issues

fikreanteneh added 3 commits August 24, 2023 22:06

Authentication

3b50345

Auth

d3a530c

Eery Feature Implemented

2685e40

fikreanteneh requested review from abrahamshimekt and bahailu-abera as code owners August 25, 2023 20:15

abrahamshimekt reviewed Aug 27, 2023

View reviewed changes

abrahamshimekt requested changes Aug 27, 2023

View reviewed changes

		var validationResult = await validator.ValidateAsync(request.UpdateCommentDto);

		Console.WriteLine(request.UpdateCommentDto);


		namespace Application.Features.Like.Handlers.Query;

		public class GetLikedPostRequestHandler : IRequestHandler<GetLikedPostRequest, List<PostDto>>{


		var customeUser = await userRepository.GetUserByEmail(user.Email);

		Console.WriteLine("---------------OKKKKKKKKKKKKK JWT");

		@@ -0,0 +1,8 @@
		namespace Application.Model;

		public class @string{

		@@ -8,8 +8,8 @@ public class Comment
		//The User That Commented
		public required int UserId { get; set; }



		[HttpPut("{PostId}")]
		public async Task<IActionResult> UpdatePost([FromBody] UpdatePostDto updatePost, int UserId, int PostId){



		[HttpPost("{PostId}")]
		public async Task<ActionResult> AddLike( int PostId)

Aait.bac.g2a.fikremariam.allfeatures #267

Are you sure you want to change the base?

Aait.bac.g2a.fikremariam.allfeatures #267

Conversation

fikreanteneh commented Aug 25, 2023

abrahamshimekt Aug 27, 2023 • edited Loading

Choose a reason for hiding this comment

abrahamshimekt Aug 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abrahamshimekt Aug 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abrahamshimekt Aug 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abrahamshimekt Aug 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abrahamshimekt Aug 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abrahamshimekt left a comment

Choose a reason for hiding this comment

abrahamshimekt Aug 27, 2023 •

edited

Loading

abrahamshimekt Aug 27, 2023 •

edited

Loading

abrahamshimekt Aug 27, 2023 •

edited

Loading

abrahamshimekt Aug 27, 2023 •

edited

Loading

abrahamshimekt Aug 27, 2023 •

edited

Loading

abrahamshimekt Aug 27, 2023 •

edited

Loading