Aait.web.g1.admas terefe.password change #438
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Son-OfAnton
requested review from
jebessaD and
TsehaynehGetaneh
as code owners
Son-OfAnton
force-pushed
the
aait.web.g1.admas-terefe.password-change
branch
from
b24cbc3 to
a544ee6
Compare
jebessaD
reviewed
Aug 30, 2023
| } | ||
|
|
||
|
|
||
| ///<div className='flex flex-col items-center text-[11px] font-poppins'> |
jebessaD
reviewed
Aug 30, 2023
| placeholder='Enter new password' | ||
| onChange={(e) => setNewPassword(e.target.value)} | ||
| /> | ||
| <Image |
There was a problem hiding this comment.
Use Icons, [react-icon package] instead of an image.
jebessaD
reviewed
Aug 30, 2023
| <div className='col-span-2 flex justify-between items-center py-3 px-5 rounded-lg bg-[#EFF3F9] w-full'> | ||
| <input | ||
| type="password" | ||
| className='focus:outline-none bg-[#EFF3F9]' |
There was a problem hiding this comment.
Utilize built-in colors instead of using hexadecimal codes.
jebessaD
reviewed
Aug 30, 2023
jebessaD
reviewed
Aug 30, 2023
| <p className='text-[10px] text-[#868686] font-light'>You can change your password here</p> | ||
| </div> | ||
| <button | ||
| className='text-[10px] font-semibold bg-[#264FAD] rounded-md text-white px-12 py-2' |
There was a problem hiding this comment.
Utilize built-in colors instead of using hexadecimal codes.
jebessaD
reviewed
Aug 30, 2023
| placeholder='Confirm new password' | ||
| onChange={(e) => setConfirmPass(e.target.value)} | ||
| /> | ||
| <Image |
There was a problem hiding this comment.
Use Icons, [react-icon package] instead of an image.
jebessaD
reviewed
Aug 30, 2023
| <div className={ `flex justify-between items-center text-md border-b ${ pathname === '/profile/my-blogs' ? 'pb-2' : 'pb-4' }` }> | ||
| <div className='flex space-x-10 text-[12px] text-[#494949] font-semibold'> | ||
| { | ||
| // links.map(link => <h3 className={ pathname === linkPathname.get(link) && `border-b-2 border-[#264FAD] -mb-5` } >{ link }</h3>) |
jebessaD
reviewed
Aug 30, 2023
|
|
||
| <div className='flex justify-between items-center w-full border-t pt-4 text-[12px]'> | ||
| <div className='flex justify-start items-center space-x-1'> | ||
| <Image |
There was a problem hiding this comment.
Use Icons [react-icon package] instead of an image.
Son-OfAnton
force-pushed
the
aait.web.g1.admas-terefe.password-change
branch
from
4801314 to
467c100
Compare
Son-OfAnton
force-pushed
the
aait.web.g1.admas-terefe.password-change
branch
from
5d8a348 to
70622ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.