Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] andualem added CRUD operations #299

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AndualemSebsbe
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Aug 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
practice ❌ Failed (Inspect) Aug 6, 2022 at 0:50AM (UTC)
practice-project-vue ❌ Failed (Inspect) Aug 6, 2022 at 0:50AM (UTC)
practice-vue ❌ Failed (Inspect) Aug 6, 2022 at 0:50AM (UTC)

Copy link
Contributor

@danielgitk danielgitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

no need to commit empty files too. (in ur components folder)

}
try {
const res = await axios.get(
`https://blog-app-backend.onrender.com/api/articles/${this.$route.params.id}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should be in a store file, and also no need to import axios, use this.$axios

`https://blog-app-backend.onrender.com/api/articles/${this.$route.params.id}`,
config
)
console.log(res)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets get rid of console.log statements

margin-top: 25px;
margin-bottom: 20px;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to add custom CSS here. we can do a similar thing using vuetify classes like mb-2 for the margin and others too. check here for spacing and here for the font styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants