Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a config option for checking java version feature #80

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create a config option for checking java version feature #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/dev/redstudio/valkyrie/Valkyrie.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ public final class Valkyrie {
public static void preInit(FMLPreInitializationEvent preInitializationEvent) {
snoozerFile = new File(preInitializationEvent.getModConfigurationDirectory() + "/" + VERSION + " Snoozer.txt");

new Thread(JvmCheckUtil::checkJavaVersion).start();
if (ValkyrieConfig.general.javaVersionCheck)
new Thread(JvmCheckUtil::checkJavaVersion).start();
}

@Mod.EventHandler
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/dev/redstudio/valkyrie/config/ValkyrieConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ public class ValkyrieConfig {

public static class GeneralConfig {

@Config.RequiresMcRestart
public boolean javaVersionCheck = true;

@Config.RequiresMcRestart
public boolean highPrecisionDepthBuffer = false;
public boolean customIcons = false;
Expand Down
2 changes: 2 additions & 0 deletions src/main/resources/assets/valkyrie/lang/en_us.lang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ jvmCheck.ignore=Ignore
valkyrie.general.general=General
valkyrie.general.general.tooltip=General configuration

valkyrie.general.general.javaversioncheck=Disable Outdated Java Version Check
valkyrie.general.general.javaversioncheck.tooltip=Enable or disable the popup when using an outdated Java version.
valkyrie.general.general.highprecisiondepthbuffer=High Precision Depth Buffer
valkyrie.general.general.highprecisiondepthbuffer.tooltip=Whether or not to use high precision depth buffer, this doesn't seem to be important or change much, but might be useful in the future.
valkyrie.general.general.windowtitle=Window Title
Expand Down