Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Optimization Section #370

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

dscervantes
Copy link
Contributor

Adding outside references to content for cost management

This is adding the Optimization section
Screenshot from 2024-06-20 12-39-51

Copy link
Member

@tahmidefaz tahmidefaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files gets updated by Discovery. I think these changes will unfortunately get reverted in the next Discovery update. We will need to update Discovery/API Sync code to natively detect and stitch together external APIs.

@tahmidefaz
Copy link
Member

@dscervantes build is failing because it can't seem to find the cost management file. Check what we do for ros. You will need to create a directory named cost-management.

You will need to move the openapi spec json to /packages/discovery/resources/api/hcc-insights/cost-management.

Copy link
Member

@tahmidefaz tahmidefaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We can activate the auto sync again when we support external refs.

@tahmidefaz tahmidefaz merged commit f0b1107 into RedHatInsights:main Jun 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants