feat: use local source for installing bonfire #427
Conversation
Victoremepunto
force-pushed
the
build-image-from-source
branch
from
923c0d2 to
5bfeeb4
Compare
Dockerfile
Outdated
| USER bonfire | ||
| WORKDIR /opt/bonfire | ||
| ENV PATH="/opt/bonfire/.local/bin:$PATH" | ||
| COPY --chown=1001:0 . . |
There was a problem hiding this comment.
This could potentially copy in the hidden . files right? Do you need to copy explicit paths here?
There was a problem hiding this comment.
yeah actually due to how we handle versions, I do - bonfire runs this scm dynamic versioning, I need the git repo metadata to get the right version
I was thinking building the wheel and installing that instead - but there's not much of a difference anyways
There was a problem hiding this comment.
that said, I still think a .dockerignore could really help keeping a bunch of not really needed files out, so I'll push that, thanks!
There was a problem hiding this comment.
I added a multi-stage build to build a wheel and then copy and install that alone, please can you give it a second look?
|
Other than what Brandon pointed out this LGTM |
No description provided.