Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homebrew install instructions #433

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

alechenninger
Copy link
Contributor

I created a homebrew tap because I am lazy and didn't want to mess with python virtual environments ;-).

The repo for the formula is here: https://github.com/redhatinsights/homebrew-bonfire

There are instructions on how to update it there, but it is easy enough to maintain so I'm happy to keep it up to date myself also.

Copy link
Collaborator

@bsquizz bsquizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding! Tested it out, and it works, so I have no problem merging... I have some questions for possible enhancements. Would you prefer to merge this now and tweak things later or would it be easier for some of this to go in now? Let me know.

  1. Should the formula just live in this repo or is it better to keep it in the separate one?
  2. Could the formula update become part of a github release pipeline? (we have a github action that releases to pypi, could the formula be updated at that point in time?)
  3. Is there a way to detect within the running app that bonfire was installed with homebrew? If so we might want to conditionally print a different message here:
    "upgrade with:\n"

@alechenninger
Copy link
Contributor Author

Thanks for reviewing!

Should the formula just live in this repo or is it better to keep it in the separate one?

Looks like this is required:

On GitHub, your repository must be named homebrew-something to use the one-argument form of brew tap. The prefix “homebrew-“ is not optional. (The two-argument form doesn’t have this limitation, but it forces you to give the full URL explicitly.)

https://docs.brew.sh/Taps

Though it does imply the instructions could be simplified per those docs.

Could the formula update become part of a github release pipeline? (we have a github action that releases to pypi, could the formula be updated at that point in time?)

I think this is definitely possible! You would grab the latest source path, hash, and the run brew update-python-resources Formula/bonfire.rb and that should do the needful. That said I'm not sure I'll have time to tinker with that.

Is there a way to detect within the running app that bonfire was installed with homebrew? If so we might want to conditionally print a different message here:

Good question. We could maybe touch a file to a known location during the install and check that?

Copy link
Collaborator

@bsquizz bsquizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good for now, enhancements can be made in future if we want :)

@bsquizz bsquizz merged commit 228e70a into RedHatInsights:master Oct 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants