feat: inject frontend context config map into pod spec #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florkbr
approved these changes
Nov 14, 2024
bsquizz
approved these changes
Dec 3, 2024
bsquizz
force-pushed
the
frontend-context-name
branch
from
0a9ff00 to
af5d461
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic env name makes it difficult to properly mount FEO generated config map which holds the frontend context metadata to pods.
@psav and I had a discussion and today, this seems to be best for enabling new FEO features in ephemeral. We have briefly discussed some possible changes to FEO, Chrome backend, and clowder in the future, but right now we don't have many options.
Please let me know your thoughts.