Skip to content

Commit

Permalink
try amending E2E tests
Browse files Browse the repository at this point in the history
- remove need of make, leverage existing manifest from release
- use UBI8 UBI image again
- remove installing go
  • Loading branch information
Victoremepunto committed Dec 9, 2024
1 parent b1a8a8a commit 7b4c9a3
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 28 deletions.
9 changes: 5 additions & 4 deletions .tekton/clowder-pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
- name: path-context
value: .
- name: prefetch-input
value:
value:
- {"type": "gomod", "path": "."}
- {"type": "gomod", "path": "./deps/controller-gen"}
- {"type": "gomod", "path": "./deps/kustomize"}
Expand Down Expand Up @@ -299,7 +299,7 @@ spec:
- use
- $(params.SOURCE_ARTIFACT)=/var/workdir/source
- name: e2e-tests
image: registry.access.redhat.com/ubi8/go-toolset:1.22.7-5.1731464728
image: registry.access.redhat.com/ubi8/ubi:8.10-1132.1732635159
workingDir: /var/workdir/source
env:
- name: MINIKUBE_HOST
Expand All @@ -311,7 +311,7 @@ spec:
valueFrom:
secretKeyRef:
name: minikube-ssh-key
key: MINIKUBE_USER
key: MINIKUBE_USER
- name: MINIKUBE_SSH_KEY
valueFrom:
secretKeyRef:
Expand All @@ -322,7 +322,8 @@ spec:
secretKeyRef:
name: minikube-ssh-key
key: MINIKUBE_ROOTDIR
script: set -e && ./ci/konflux_minikube_e2e_tests.sh
# FIXME: this should be handled from the script itself
script: set -ex && dnf install -y git openssh-clients python3.12 && ci/konflux_minikube_e2e_tests.sh
volumes:
# New volume to store a copy of the source code accessible only to this Task.
- name: workdir
Expand Down
9 changes: 5 additions & 4 deletions .tekton/clowder-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ spec:
- use
- $(params.SOURCE_ARTIFACT)=/var/workdir/source
- name: e2e-tests
image: registry.access.redhat.com/ubi8/go-toolset:1.22.7-5.1731464728
image: registry.access.redhat.com/ubi8/ubi:8.10-1132.1732635159
workingDir: /var/workdir/source
env:
- name: MINIKUBE_HOST
Expand All @@ -301,7 +301,7 @@ spec:
valueFrom:
secretKeyRef:
name: minikube-ssh-key
key: MINIKUBE_USER
key: MINIKUBE_USER
- name: MINIKUBE_SSH_KEY
valueFrom:
secretKeyRef:
Expand All @@ -312,7 +312,8 @@ spec:
secretKeyRef:
name: minikube-ssh-key
key: MINIKUBE_ROOTDIR
script: set -e && ./ci/konflux_minikube_e2e_tests.sh
# FIXME: this should be handled from the script itself
script: set -ex && dnf install -y git openssh-clients python3.12 && ci/konflux_minikube_e2e_tests.sh
volumes:
# New volume to store a copy of the source code accessible only to this Task.
- name: workdir
Expand Down Expand Up @@ -557,4 +558,4 @@ spec:
- name: git-auth
secret:
secretName: '{{ git_auth_secret }}'
status: {}
status: {}
25 changes: 12 additions & 13 deletions build/kube_setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ if ! command -v jq; then
exit 1
fi

# GO is required for yq, check if go is installed
echo "*** Checking for 'go' ..."
if ! command -v go; then
echo "*** 'go' not found in path. Please install go with:"
[[ $PLATFORM == "Darwin" ]] && echo " 'brew install golang' or the instructions at https://golang.org/doc/install" \
|| echo " sudo dnf install golang"
exit 1
fi
## GO is required for yq, check if go is installed
#echo "*** Checking for 'go' ..."
#if ! command -v go; then
# echo "*** 'go' not found in path. Please install go with:"
# [[ $PLATFORM == "Darwin" ]] && echo " 'brew install golang' or the instructions at https://golang.org/doc/install" \
# || echo " sudo dnf install golang"
# exit 1
#fi

# kubectl is required for interactions with the cluster.
if [ -n "${KUBECTL_CMD}" ]; then
Expand All @@ -52,11 +52,11 @@ source build/.build_venv/bin/activate
pip install --upgrade pip setuptools wheel
pip install pyyaml

GO_BIN_PATH="$(go env GOPATH)/bin"
#GO_BIN_PATH="$(go env GOPATH)/bin"
#
#export PATH="$PATH:$GO_BIN_PATH"

export PATH="$PATH:$GO_BIN_PATH"

declare -a array BG_PIDS=()
declare -a BG_PIDS=()

ROOT_DIR=$(pwd)
DOWNLOAD_DIR="build/operator_bundles"
Expand Down Expand Up @@ -188,7 +188,6 @@ function install_prometheus_operator {
cd "$ROOT_DIR"
}


function install_cyndi_operator {
OPERATOR_NS=cyndi-operator-system
DEPLOYMENT=cyndi-operator-controller-manager
Expand Down
13 changes: 6 additions & 7 deletions ci/konflux_minikube_e2e_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ set -exv

mkdir -p /var/workdir/bin
cd /var/workdir/bin
ln -s /usr/libexec/platform-python3.6 python3

export KUBEBUILDER_ASSETS=/var/workdir/testbin/bin

Expand Down Expand Up @@ -71,7 +70,7 @@ preferences: {}
EOM

export PATH="$KUBEBUILDER_ASSETS:$PATH"
export PATH="/root/go/bin:$PATH"
#export PATH="/root/go/bin:$PATH"

export KUBECONFIG=$PWD/kube-config
export KUBECTL_CMD="kubectl "
Expand All @@ -84,11 +83,11 @@ export IMAGE_TAG=`git rev-parse --short=8 HEAD`

$KUBECTL_CMD create namespace clowder-system

mkdir artifacts
#mkdir artifacts
#
#make release

make release

cat manifest.yaml > artifacts/manifest.yaml
#cat manifest.yaml > artifacts/manifest.yaml

$KUBECTL_CMD apply -f manifest.yaml --validate=false -n clowder-system

Expand Down Expand Up @@ -125,4 +124,4 @@ for pod in $STRIMZI_PODS; do
done
set -e

exit $KUTTL_RESULT
exit $KUTTL_RESULT

0 comments on commit 7b4c9a3

Please sign in to comment.