Skip to content

Commit

Permalink
restore -e flag to fail on errors
Browse files Browse the repository at this point in the history
  • Loading branch information
Victoremepunto committed Dec 10, 2024
1 parent cb58a90 commit b3aaabc
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .tekton/clowder-pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ spec:
- name: unit-tests
image: registry.access.redhat.com/ubi8/go-toolset:1.22.7-5.1731464728
workingDir: /var/workdir/source
script: make -dn test
script: set -xe && git config --global --add safe.directory /var/workdir/source && make -dn test
volumes:
# New volume to store a copy of the source code accessible only to this Task.
- name: workdir
Expand Down Expand Up @@ -323,7 +323,7 @@ spec:
name: minikube-ssh-key
key: MINIKUBE_ROOTDIR
# FIXME: this should be handled from the script itself
script: set -ex && dnf install -y git openssh-clients python3.12 && ci/konflux_minikube_e2e_tests.sh
script: set -ex && dnf install -y git openssh-clients python3.12 make && ci/konflux_minikube_e2e_tests.sh
volumes:
# New volume to store a copy of the source code accessible only to this Task.
- name: workdir
Expand Down
4 changes: 2 additions & 2 deletions .tekton/clowder-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ spec:
- name: unit-tests
image: registry.access.redhat.com/ubi8/go-toolset:1.22.7-5.1731464728
workingDir: /var/workdir/source
script: set -xe && make test
script: set -xe && git config --global --add safe.directory /var/workdir/source && make -dn test
volumes:
# New volume to store a copy of the source code accessible only to this Task.
- name: workdir
Expand Down Expand Up @@ -313,7 +313,7 @@ spec:
name: minikube-ssh-key
key: MINIKUBE_ROOTDIR
# FIXME: this should be handled from the script itself
script: set -ex && dnf install -y git openssh-clients python3.12 && ci/konflux_minikube_e2e_tests.sh
script: set -ex && dnf install -y git openssh-clients python3.12 make && ci/konflux_minikube_e2e_tests.sh
volumes:
# New volume to store a copy of the source code accessible only to this Task.
- name: workdir
Expand Down
1 change: 0 additions & 1 deletion build/template_check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

set -exv


python3 -m venv "build/.build_venv"
source build/.build_venv/bin/activate
pip install pyyaml
Expand Down

0 comments on commit b3aaabc

Please sign in to comment.