-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Konfluxing #1056
Konfluxing #1056
Conversation
/retest |
010ef06
to
bb8ee74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reviewing the Tekton tasks here, I can't understand why the on-push one is running on every commit push, and why the on-pull-request one is actually not running at all.
I would suggest if possible, to, on a separate PR, simply onboard Clowder as is, and merge those tasks directly (even if they don't build successfully) - and then on this PR, we can rebase on top of it, so that we can see the changes you are adding on this PR (as opposed to, the full Tekton task definition).
f55675d
to
e85d4ba
Compare
@maknop I've reviewed your PR, thank you very much for doing the actual Konflux onboarding first, as a separate PR, and rebased this PR on top, it is now easier to see what you are adding on top in this PR. However, I've noticed the pipeline you used was incorrect (it was the I've fixed that with #1074, please rebase your changes once again, we should see even less LOC changed from your PR. My early comment about the target branch for the trigger is still valid, please do not change it, it needs to be set to master CC @psav |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed the tasks are using older SHAs than what's upstream, please revert the ones that are using older than what's upstream
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, thanks for adding the changes to the Tekton tasks
@psav this still needs your approval, I have only reviewed the Tekton bits, they look good, we'll consider adding a follow up to add an ITS to run the EC in PRs
Requested changes to Tekton tasks have been addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Victoremepunto and I went through this today for a final review - Regrettably there are some issues that we need to address/fix/explain before this can be merged, however these should be relatively quick to remediate with the right guidance from the team/konflux.
Migrating Clowder to use Konflux for building images. This pipeline will also consist of running the E2E and unit tests.