Add documentation for watchers #1125
Open
+115
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
psav
commented
Jan 15, 2025
psav
commented
- Add documentation for watcher/handler mechanism
* Add documentation for watcher/handler mechanism
maknop
reviewed
Jan 15, 2025
| ```golang | ||
| func deploymentUpdateFunc(e event.UpdateEvent) bool { | ||
| objOld := e.ObjectOld.(*apps.Deployment) | ||
| objNew := e.ObjectNew.(*apps.Deployment) |
There was a problem hiding this comment.
For lines 246 and 247, doesn't this just set the same Deployment object to both objOld and objNew?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.