Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tailorings): Implement group selection #2306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bastilian
Copy link
Member

@bastilian bastilian commented Dec 5, 2024

This enables the group selection for the rules table.

How to test:

1.a) Open the "Create Policy" wizard and advance to the "Rules" step
1.b) Open the Edit Policy on the rules tab
2) Select and deselect a group and/or a rule and verify the selected items are correctly updated
3) Test the same with and without filters set

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@bastilian bastilian force-pushed the RHINENG-14557 branch 4 times, most recently from ae84d3c to 721839e Compare December 18, 2024 10:27
@bastilian bastilian marked this pull request as ready for review December 18, 2024 10:33
@bastilian bastilian requested a review from a team as a code owner December 18, 2024 10:33
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 32 lines in your changes missing coverage. Please review.

Project coverage is 68.47%. Comparing base (492cb3b) to head (c720025).

Files with missing lines Patch % Lines
...orks/AsyncTableTools/hooks/useTableView/helpers.js 11.11% 24 Missing ⚠️
.../AsyncTableTools/hooks/useTableView/views/index.js 0.00% 3 Missing ⚠️
...TableTools/hooks/useTableView/views/treeChopper.js 83.33% 3 Missing ⚠️
...sentationalComponents/RulesTable/RulesTableRest.js 0.00% 1 Missing ⚠️
...alComponents/Tailorings/components/TailoringTab.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2306      +/-   ##
==========================================
+ Coverage   68.18%   68.47%   +0.28%     
==========================================
  Files         357      358       +1     
  Lines        6481     6524      +43     
  Branches     2085     2110      +25     
==========================================
+ Hits         4419     4467      +48     
+ Misses       2062     2057       -5     
Flag Coverage Δ
combined 68.47% <38.46%> (+0.28%) ⬆️
cypress 42.39% <7.69%> (-0.42%) ⬇️
jest 67.71% <38.46%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AsToNlele AsToNlele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, looks like I can't add an unselected rule to selected
Selected an unselected rule
image
Can't find the selected rule in selected. I've tried clearing the filter
image

@bastilian
Copy link
Member Author

@AsToNlele I believe this may be related to https://issues.redhat.com/browse/RHINENG-14621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants