Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-8201 - docker-compose based dev-setup #143

Merged

Conversation

patilsuraj767
Copy link
Collaborator

Documentation added in docs/dev-setup.md

@patilsuraj767 patilsuraj767 changed the title Fixes #RHINENG-8201 - docker-compose based dev-setup RHINENG-8201 - docker-compose based dev-setup Mar 6, 2024
@patilsuraj767 patilsuraj767 force-pushed the docker-compose-dev-setup branch 2 times, most recently from d5673a7 to 9bb8f83 Compare March 6, 2024 08:55
scripts/docker-compose.yml Outdated Show resolved Hide resolved
scripts/docker-compose.yml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@patilsuraj767 patilsuraj767 force-pushed the docker-compose-dev-setup branch from 9bb8f83 to 8fbf669 Compare March 21, 2024 08:52
Copy link
Collaborator

@r14chandra r14chandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @patilsuraj767 for resolving all the comments!
I just added one suggestion.

docs/dev-setup.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@r14chandra r14chandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. Thanks for working on it! 🚀

@r14chandra r14chandra merged commit 83532e2 into RedHatInsights:master Mar 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants