RHINENG-9142 Playbook tasks reorder on requesting GET /playbooks #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgaikwad
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
In my opinion, this looks like a design problem. At the moment, config-manager do not have actionable tasks in removal playbooks for services except insights.
That's why this change might make sense so approving it for now.
Once other services will have actionable tasks under removal playbooks, one needs to revisit this functionality. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do we need this change? 💭
Playbook tasks are being reordered every time we request GET /playbooks. The
Insightsplaybook should be the first to be executed then the other services.Documentation update? 📝
💂♂️ Checklist 🎯
Additional 📣
Feel free to add any other relevant details such as links, notes, screenshots, here.