Make it easier to run the database #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull a pre-built database container. Add variables for database image and port for easy overrides. Detect container runtime with different precedence based on OS.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15 +/- ##
========================================
Coverage 80.82% 80.82%
========================================
Files 9 9
Lines 73 73
========================================
Hits 59 59
Misses 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
samdoran
force-pushed
the
run-db-task
branch
2 times, most recently
from
03f12ec to
38f1cd3
Compare
samdoran
force-pushed
the
run-db-task
branch
14 times, most recently
from
90b0b17 to
91998cb
Compare
Make defaults to /bin/sh, which is dash on Ubuntu and causes problems with using type.
This will be redundant in normal operations but will show helpful errors if something odd happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull a pre-built database container.
Add variables for database image and port for easy overrides.
Detect container runtime with different precedence based on OS.