Theedge 3710: Add activation key to image model and add it on image builder request #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2360 +/- ##
==========================================
+ Coverage 62.11% 62.31% +0.20%
==========================================
Files 88 88
Lines 13232 13244 +12
==========================================
+ Hits 8219 8253 +34
+ Misses 4336 4312 -24
- Partials 677 679 +2 ☔ View full report in Codecov by Sentry. |
|
/retest |
1 similar comment
|
/retest |
|
/rebase |
|
This pull request is now in conflicts. Could you fix it @adeliaferreira? 🙏 |
ldjebran
reviewed
Jan 8, 2024
|
This pull request needs all conversation threads to be resolved. Could you fix it @adeliaferreira? 🙏 |
ldjebran
reviewed
Jan 8, 2024
ldjebran
reviewed
Jan 8, 2024
…ion key on edge-api Signed-off-by: Adelia Ferreira <[email protected]>
Signed-off-by: Adelia Ferreira <[email protected]>
Signed-off-by: Adelia Ferreira <[email protected]>
…uration for the new image Signed-off-by: Adelia Ferreira <[email protected]>
adeliaferreira
force-pushed
the
THEEDGE-3710
branch
from
463bc1f to
23f948a
Compare
|
@ldjebran I made all the changes that you mentioned on the review and we sync on the slack about change BaseURL and Server URL to config, let me know if I missed something, but I feel it's ready to go on this one. |
adeliaferreira
requested review from
maxamillion,
acosferreira,
loadtheaccumulator,
AaronH88,
thom-at-redhat,
mgold1234,
tomershinhar,
de1987,
omaciel and
lahavyuv86
as code owners
adeliaferreira
changed the title
ldjebran
reviewed
Jan 9, 2024
ldjebran
reviewed
Jan 9, 2024
ldjebran
reviewed
Jan 9, 2024
|
missing related changes to deploy/clowdapp.yaml |
|
missing unit-test |
|
/retest |
Signed-off-by: Adelia Ferreira <[email protected]>
Signed-off-by: Adelia Ferreira <[email protected]>
… clowapp.yaml Signed-off-by: Adelia Ferreira <[email protected]>
… object to image-builder Signed-off-by: Adelia Ferreira <[email protected]>
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add the activation key model to image model, save it on database after received it though api and include it inside customizations object on image builder client communication.
FIXES: THEEDGE-3710
Type of change
What is it?