Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRCD secrets #125

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Victoremepunto
Copy link
Contributor

What?

This adds CRCD variables from Vault to be able to run the tests in the CRCD cluster (compared to the Ephemeral cluster).

Why?

The Ephemeral cluster is busted ATM and this allows the tests to run on a diff. cluster

How?

We have changed the default cluster but we need the right credentials injected into the pipeline, this PR does that

Testing

no - it should actually be able to run the Smoke tests now.

Secure Coding Practices Checklist Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5eeb622) 45.72% compared to head (abb0f44) 45.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   45.72%   45.72%           
=======================================
  Files          18       18           
  Lines        1334     1334           
=======================================
  Hits          610      610           
  Misses        682      682           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants