Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Expose PSQL port override via env var #129

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lindseyburnett
Copy link

What?

Update the docker-compose.yml file to allow psql to run on a different port.

Why?

I was trying to run the export service locally while working on the subscription watch/export service integration, and couldn't because the subscription watch db was already using the default port.

How?

Describe how the change is implemented. Any noteable new libaries, APIs, or features.

Testing

Did you add any tests for the change?

Anything Else?

Any other notes about the PR that would be useful for the reviewer.

Secure Coding Practices Checklist Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@lindseyburnett lindseyburnett force-pushed the lburnett/psql-port-parameter branch from 6174bc3 to dbf0fdb Compare February 14, 2024 18:10
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5eeb622) 45.72% compared to head (dbf0fdb) 45.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   45.72%   45.72%           
=======================================
  Files          18       18           
  Lines        1334     1334           
=======================================
  Hits          610      610           
  Misses        682      682           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants